You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2022/10/12 10:53:49 UTC

[GitHub] [syncope] ilgrosso commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993304181


##########
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##########
@@ -61,8 +61,23 @@ public abstract class AbstractService implements JAXRSService {
 
     protected String getActualKey(final AnyDAO<?> dao, final String pretendingKey) {
         String actualKey = pretendingKey;
-        if (!SyncopeConstants.UUID_PATTERN.matcher(pretendingKey).matches()) {
-            actualKey = dao.findKey(pretendingKey);
+        if (uriInfo.getPathParameters(true).containsKey("key")) {

Review Comment:
   Can we add here `actualKey == null` as first condition the `if` clause? I'd rather avoid decoding path parameters if not strictly needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org