You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2016/09/14 14:15:20 UTC
[jira] [Updated] (HADOOP-13612) FileSystem static mkdirs(FS, path,
permissions) to invoke FS.mkdirs(path, permissions)
[ https://issues.apache.org/jira/browse/HADOOP-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-13612:
------------------------------------
Attachment: HADOOP-13612-branch-2-001.patch
Patch 001, calls the relevant mkdirs operation.
No tests; people who understand HDFS permissions need to review this to see if there is something fundamentally wrong with this approach
> FileSystem static mkdirs(FS, path, permissions) to invoke FS.mkdirs(path, permissions)
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-13612
> URL: https://issues.apache.org/jira/browse/HADOOP-13612
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 2.7.3
> Reporter: Steve Loughran
> Attachments: HADOOP-13612-branch-2-001.patch
>
>
> Currently {{FileSystem}}'s static {{mkdirs(FileSystem fs, Path dir, FsPermission permission)}} creates the directory in a two step operation
> {code}
> // create the directory using the default permission
> boolean result = fs.mkdirs(dir);
> // set its permission to be the supplied one
> fs.setPermission(dir, permission);
> {code}
> this isn't atomic and creates a risk of race/security conditions. *This code is used in production*
> Better to simply forward to mkdirs(path, permissions).
> is there any reason to not do that?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org