You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 08:42:29 UTC
[GitHub] [arrow] wgtmac opened a new pull request, #14204: ARROW-17814: [C++] Remove make_unique reimplementation
wgtmac opened a new pull request, #14204:
URL: https://github.com/apache/arrow/pull/14204
Use std::make_unique instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1255864919
See also: https://arrow.apache.org/docs/developers/cpp/development.html#code-style-linting-and-ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1255883197
#14218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1254762926
https://issues.apache.org/jira/browse/ARROW-17814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1255833040
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b512f69a9f4b419b897eee14b2127690...df6b434e582b410e9ae3580c1d9a3a98/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1254762953
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1255013326
I rebased and fixed conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1255832898
Benchmark runs are scheduled for baseline = 0310add1776054a67aacfb1a7bc0f569a19c7628 and contender = 4cb7b500d5baf1d2c88b0438dda0f4396724667f. 4cb7b500d5baf1d2c88b0438dda0f4396724667f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/333036200084406aada6d4cdbc7ef3c9...6de3ee0af8b44d6cad4ccab33fa4deeb/)
[Failed :arrow_down:0.55% :arrow_up:0.24%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/daf12105507842de8473da7b221f8c76...1c26c9efa1824627b180a59a9cd5ec9f/)
[Failed :arrow_down:1.1% :arrow_up:0.27%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b512f69a9f4b419b897eee14b2127690...df6b434e582b410e9ae3580c1d9a3a98/)
[Finished :arrow_down:0.46% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6e3fd536de764eb6a3b1eadc1780a4f6...cbd971bede30486788ed11ea7fdcd1bd/)
Buildkite builds:
[Finished] [`4cb7b500` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1549)
[Failed] [`4cb7b500` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1566)
[Failed] [`4cb7b500` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1549)
[Finished] [`4cb7b500` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1563)
[Finished] [`0310add1` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1548)
[Finished] [`0310add1` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1565)
[Failed] [`0310add1` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1548)
[Finished] [`0310add1` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1562)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1255864383
@wgtmac This breaks our lint: https://github.com/apache/arrow/actions/runs/3105831802/jobs/5031935208#step:5:866
```diff
--- /arrow/cpp/src/arrow/type.cc
+++ /arrow/cpp/src/arrow/type.cc (after clang format)
@@ -1723,8 +1723,7 @@
SchemaBuilder::SchemaBuilder(std::vector<std::shared_ptr<Field>> fields,
ConflictPolicy policy,
Field::MergeOptions field_merge_options) {
- impl_ = std::make_unique<Impl>(std::move(fields), nullptr, policy,
- field_merge_options);
+ impl_ = std::make_unique<Impl>(std::move(fields), nullptr, policy, field_merge_options);
}
SchemaBuilder::SchemaBuilder(const std::shared_ptr<Schema>& schema, ConflictPolicy policy,
...
```
Could you fix this as a follow-up pull request? Or do you want me to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1254780179
> Thanks! Is it also possible to remove occurrences of `using std::make_unique` and instead write `std::make_unique` in full?
Thanks for the review! Please check it again. @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1255876381
Oops, I don't know how I missed that. @kou I'd be glad if you could do it :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14204:
URL: https://github.com/apache/arrow/pull/14204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1255024899
> I rebased and fixed conflicts.
I have done the same thing. Sorry for missing your commit. @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1254781619
I'll just wait for CI now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14204: ARROW-17814: [C++] Remove make_unique reimplementation
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14204:
URL: https://github.com/apache/arrow/pull/14204#issuecomment-1255881681
OK. I'll do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org