You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "tomsun28 (via GitHub)" <gi...@apache.org> on 2023/05/03 07:02:32 UTC

[GitHub] [shenyu] tomsun28 opened a new pull request, #4605: fix can not load favicon.ico in dashboard

tomsun28 opened a new pull request, #4605:
URL: https://github.com/apache/shenyu/pull/4605

   fix can not load favicon.ico in dashboard
   
   relate shenyu-dashboard pr https://github.com/apache/shenyu-dashboard/pull/278 
   
   before:
   
   <img width="342" alt="2023-05-03 14 52 00" src="https://user-images.githubusercontent.com/24788200/235849157-6846c605-e72b-4f74-b73e-8aacabd6afae.png">
   
   after:
   
   <img width="325" alt="2023-05-03 14 53 10" src="https://user-images.githubusercontent.com/24788200/235849330-233db7c2-79c1-4364-b8f1-6b13c78cc17c.png">
   
   
   Make sure that:
   
   - [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [x] You submit test cases (unit or integration tests) that back your changes.
   - [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] li-keguo merged pull request #4605: fix can not load favicon.ico in dashboard

Posted by "li-keguo (via GitHub)" <gi...@apache.org>.
li-keguo merged PR #4605:
URL: https://github.com/apache/shenyu/pull/4605


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] tomsun28 commented on pull request #4605: fix can not load favicon.ico in dashboard

Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 commented on PR #4605:
URL: https://github.com/apache/shenyu/pull/4605#issuecomment-1532710809

   > Please use the file commit after building the front-end repository
   
   Updated. @li-keguo Please review. thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] li-keguo commented on pull request #4605: fix can not load favicon.ico in dashboard

Posted by "li-keguo (via GitHub)" <gi...@apache.org>.
li-keguo commented on PR #4605:
URL: https://github.com/apache/shenyu/pull/4605#issuecomment-1532669475

   Please use the file commit after building the front-end repository


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org