You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2009/08/02 15:08:14 UTC
[jira] Created: (WICKET-2410) AjaxRequestTarget could skip
component when its ancestor is added too
AjaxRequestTarget could skip component when its ancestor is added too
---------------------------------------------------------------------
Key: WICKET-2410
URL: https://issues.apache.org/jira/browse/WICKET-2410
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4.0
Reporter: Sven Meier
Priority: Minor
Attachments: AjaxRequestTarget.diff
Say you have the following component hierarchy:
Page
-> Component A
-> Component B
Now component B is added to an AJAXRequestTarget for rendering, followed by another call to addComponent() with component A.
This results in component B rendered twice to the AJAX response, first standalone, then embedded in A's markup.
The attached patch skips responding of a component when its parent is added too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2410) AjaxRequestTarget could skip
component when its ancestor is added too
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743748#action_12743748 ]
Sven Meier commented on WICKET-2410:
------------------------------------
Thanks.
> AjaxRequestTarget could skip component when its ancestor is added too
> ---------------------------------------------------------------------
>
> Key: WICKET-2410
> URL: https://issues.apache.org/jira/browse/WICKET-2410
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Sven Meier
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4.1
>
> Attachments: AjaxRequestTarget.diff
>
>
> Say you have the following component hierarchy:
> Page
> -> Component A
> -> Component B
> Now component B is added to an AJAXRequestTarget for rendering, followed by another call to addComponent() with component A.
> This results in component B rendered twice to the AJAX response, first standalone, then embedded in A's markup.
> The attached patch skips responding of a component when its parent is added too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2410) AjaxRequestTarget could skip
component when its ancestor is added too
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier updated WICKET-2410:
-------------------------------
Attachment: AjaxRequestTarget.diff
Proposed change for AjaxRequestTarget.
> AjaxRequestTarget could skip component when its ancestor is added too
> ---------------------------------------------------------------------
>
> Key: WICKET-2410
> URL: https://issues.apache.org/jira/browse/WICKET-2410
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Sven Meier
> Priority: Minor
> Attachments: AjaxRequestTarget.diff
>
>
> Say you have the following component hierarchy:
> Page
> -> Component A
> -> Component B
> Now component B is added to an AJAXRequestTarget for rendering, followed by another call to addComponent() with component A.
> This results in component B rendered twice to the AJAX response, first standalone, then embedded in A's markup.
> The attached patch skips responding of a component when its parent is added too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2410) AjaxRequestTarget could skip
component when its ancestor is added too
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2410.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4.1
Assignee: Igor Vaynberg
> AjaxRequestTarget could skip component when its ancestor is added too
> ---------------------------------------------------------------------
>
> Key: WICKET-2410
> URL: https://issues.apache.org/jira/browse/WICKET-2410
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Sven Meier
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.4.1
>
> Attachments: AjaxRequestTarget.diff
>
>
> Say you have the following component hierarchy:
> Page
> -> Component A
> -> Component B
> Now component B is added to an AJAXRequestTarget for rendering, followed by another call to addComponent() with component A.
> This results in component B rendered twice to the AJAX response, first standalone, then embedded in A's markup.
> The attached patch skips responding of a component when its parent is added too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2410) AjaxRequestTarget could skip
component when its ancestor is added too
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739186#action_12739186 ]
Martin Grigorov commented on WICKET-2410:
-----------------------------------------
I use a similar approach in my customized Wicket build for performance reasons - it saves time in HTML rendering.
I vote for this improvement.
> AjaxRequestTarget could skip component when its ancestor is added too
> ---------------------------------------------------------------------
>
> Key: WICKET-2410
> URL: https://issues.apache.org/jira/browse/WICKET-2410
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.0
> Reporter: Sven Meier
> Priority: Minor
> Attachments: AjaxRequestTarget.diff
>
>
> Say you have the following component hierarchy:
> Page
> -> Component A
> -> Component B
> Now component B is added to an AJAXRequestTarget for rendering, followed by another call to addComponent() with component A.
> This results in component B rendered twice to the AJAX response, first standalone, then embedded in A's markup.
> The attached patch skips responding of a component when its parent is added too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.