You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/12 01:20:13 UTC

[GitHub] [beam] shehzaadn-vd commented on a change in pull request #13686: [BEAM-10961] Enabled strict dependency on sdks-extensions

shehzaadn-vd commented on a change in pull request #13686:
URL: https://github.com/apache/beam/pull/13686#discussion_r574937931



##########
File path: sdks/java/extensions/sketching/build.gradle
##########
@@ -26,15 +27,14 @@ def streamlib_version = "2.9.5"
 def tdigest_version = "3.2"
 
 dependencies {
+  compile library.java.slf4j_api

Review comment:
       @ibzib I'm curious how to determine whether this project contains loggers, and why removing this particular dependency entirely seems safer than removing others (where we are adding permitUnusedDeclared).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org