[GitHub] [druid] a2l007 commented on pull request #10284: Add dynamic coordinator config that allows control over how many segments are considered when picking a segment to move.

[GitBox <gi...@apache.org>]

a2l007 commented on pull request #10284:
URL: https://github.com/apache/druid/pull/10284#issuecomment-674208552


   Would it make sense to perform the segment limiting for each `ServerHolder` individually rather than short circuiting the entire selection flow? Say if set `maxSegmentsToConsiderPerMove` to 50, it will consider only 50 segments per `ServerHolder` after which it will run the selection process for the next `ServerHolder`. That way, we can ensure that ReservoirSegmentSampler considers all the given servers before making the selection.
   Also it might be more convenient for the user to express this parameter as a percentage of segments to select from rather than a number, but i guess that might take away some of the performance gain that we're trying to achieve here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org