[GitHub] [flink] zentol commented on a change in pull request #18534: [FLINK-25849] Add TaskManager session id to JobMaster.registerTaskManager

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #18534:
URL: https://github.com/apache/flink/pull/18534#discussion_r793740065



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterExecutionDeploymentReconciliationTest.java
##########
@@ -270,9 +271,11 @@ private void registerTaskExecutorAndOfferSlots(
             throws ExecutionException, InterruptedException {
         jobMasterGateway
                 .registerTaskManager(
-                        taskExecutorGateway.getAddress(),
-                        taskManagerLocation,
                         jobId,
+                        TaskManagerRegistrationInformation.create(
+                                taskExecutorGateway.getAddress(),
+                                taskManagerLocation,
+                                TestingUtils.zeroUUID()),

Review comment:
       I'm wondering whether this util gives us anything compared to `UUID.randomUUID();` We aren't saving lines, and if this is re-used incorrectly we can easily have 2 TMs with the same session ID.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org