You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by jayapalu <gi...@git.apache.org> on 2015/09/22 07:58:51 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-8891: Fixed default iptables r...

GitHub user jayapalu opened a pull request:

    https://github.com/apache/cloudstack/pull/867

    CLOUDSTACK-8891: Fixed default iptables rules on VR  for guest traffic

    VR default iptables rules in INPUT chain are configured partially.
    In CsAddress.py rules are configured while configuring public interface, guest interface post configuration is missed. Fixed to configure guest post configuration so that iptables rules are configured.
    
    Testing:
    1. Deployed vm in the network.
    2.iptables rules on the VR configured correctly.
    3.VM got the dhcp ip address from the VR.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jayapalu/cloudstack CLOUDSTACK-8891

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/867.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #867
    
----
commit 276fa531c768b2f4be2b80d128a488f36dff29a2
Author: Jayapal <ja...@citrix.com>
Date:   2015-09-22T05:03:58Z

    CLOUDSTACK-8891: Fixed default iptables rules on VR  for guest traffic

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8891: Fixed default iptables r...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/867


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8891: Fixed default iptables r...

Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/867#issuecomment-142922291
  
    @jayapalu @karuturi
    
    We, @remibergsma, Funs and I will test the 3 PRs which are VR related now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8891: Fixed default iptables r...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/867#discussion_r40195834
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py ---
    @@ -116,6 +116,7 @@ def has_chain(self, table, chain):
         def has_rule(self, new_rule):
             for r in self.get():
                 if new_rule == r:
    +                logging.debug("new rule and r are same marking as seen")
    --- End diff --
    
    For somebody else this logline might be very odd to read


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8891: Fixed default iptables r...

Posted by jayapalu <gi...@git.apache.org>.
Github user jayapalu commented on the pull request:

    https://github.com/apache/cloudstack/pull/867#issuecomment-142837601
  
    @wido updated the patch. Deleted the log.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---