[GitHub] [arrow] thisisnic commented on pull request #34825: GH-34775: [R] arrow_table: as.data.frame() sometimes returns a tbl and sometimes a data.frame

["thisisnic (via GitHub)" <gi...@apache.org>]

thisisnic commented on PR #34825:
URL: https://github.com/apache/arrow/pull/34825#issuecomment-1494547751

   OK, not loving this solution as I've got it so far, as the failing tests are due to the fact that we use `as.data.frame()` internally in lots of functions like `read_feather()` etc, so the knock-on effect of this change is that we'd be returning `data.frame`s in more circumstances than I anticipated, and I don't want to do this.
   
   We can't just swap it for `as_tibble()` in these functions as we don't have the `tibble` package as a dependency.
   
   I could write a new internal function for use in these circumstances which returns tibbles if the package is installed or `data.frame`s if not, but that feels wrong too.
   
   May revert this PR to just fix the argument-ordering bug, and leave `as.data.frame()` as a function which usually returns tibbles.
   
   Would be good to get your thoughts here, @paleolimbot 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org