[GitHub] [hbase] nyl3532016 commented on a change in pull request #3233: HBASE-25851 Make LoadBalancer not extend Configurable interface

[GitBox <gi...@apache.org>]

nyl3532016 commented on a change in pull request #3233:
URL: https://github.com/apache/hbase/pull/3233#discussion_r627129650



##########
File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
##########
@@ -100,9 +99,11 @@ protected BaseLoadBalancer(MetricsBalancer metricsBalancer) {
     this.metricsBalancer = (metricsBalancer != null) ? metricsBalancer : new MetricsBalancer();
   }
 
-  @Override
-  public void setConf(Configuration conf) {
-    this.config = conf;
+  protected final Configuration getConf() {
+    return provider.getConfiguration();
+  }
+
+  protected void setConf(Configuration conf) {

Review comment:
       I wonder after `setconf`, maybe `getconf` is expired result, so `setconf` should be none parameter, only use provider's conf ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org