You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Matt Burgess <ma...@gmail.com> on 2015/05/29 01:12:08 UTC
Review Request 34749: DRILL-3199: GenericAccessor doesn't support
isNull
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34749/
-----------------------------------------------------------
Review request for drill.
Repository: drill-git
Description
-------
When calling isNull() from a result set, if the method gets delegated/propagated to a GenericAccessor, it throws an UnsupportedOperationException. Since GenericAccessor uses its underlying ValueVector for most other methods, I think it should also delegate the isNull() method and return whatever comes back from the ValueVector.isNull() call.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java 347cf26
exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/34749/diff/
Testing
-------
Patch provides implementation of the isNull() method, along with unit tests covering 100% of the GenericAccessor class
Thanks,
Matt Burgess
Re: Review Request 34749: DRILL-3199: GenericAccessor doesn't support
isNull
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34749/#review85646
-----------------------------------------------------------
Quick, initial comments.
exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java
<https://reviews.apache.org/r/34749/#comment137319>
We should mark this static final.
exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java
<https://reviews.apache.org/r/34749/#comment137324>
The accessor should throw IOOB rather than IAE. This complies with the contract as well (assuming bounds checking is enabled).
exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java
<https://reviews.apache.org/r/34749/#comment137320>
Please be consistent with your styling. We should either use whitespaces everywhere inside paranthesis or never use them.
- Hanifi Gunes
On May 28, 2015, 11:12 p.m., Matt Burgess wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34749/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 11:12 p.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> When calling isNull() from a result set, if the method gets delegated/propagated to a GenericAccessor, it throws an UnsupportedOperationException. Since GenericAccessor uses its underlying ValueVector for most other methods, I think it should also delegate the isNull() method and return whatever comes back from the ValueVector.isNull() call.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java 347cf26
> exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34749/diff/
>
>
> Testing
> -------
>
> Patch provides implementation of the isNull() method, along with unit tests covering 100% of the GenericAccessor class
>
>
> Thanks,
>
> Matt Burgess
>
>
Re: Review Request 34749: DRILL-3199: GenericAccessor doesn't support
isNull
Posted by Matt Burgess <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34749/
-----------------------------------------------------------
(Updated June 9, 2015, 2:08 a.m.)
Review request for drill.
Repository: drill-git
Description
-------
When calling isNull() from a result set, if the method gets delegated/propagated to a GenericAccessor, it throws an UnsupportedOperationException. Since GenericAccessor uses its underlying ValueVector for most other methods, I think it should also delegate the isNull() method and return whatever comes back from the ValueVector.isNull() call.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java 347cf26
exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/34749/diff/
Testing
-------
Patch provides implementation of the isNull() method, along with unit tests covering 100% of the GenericAccessor class
Thanks,
Matt Burgess