You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2023/06/19 11:13:19 UTC

[GitHub] [doris] xinyiZzz opened a new pull request, #20992: [fix](profile) avoid unnecessary refresh profile of TabletsChannel

xinyiZzz opened a new pull request, #20992:
URL: https://github.com/apache/doris/pull/20992

   ## Proposed changes
   
   Before, refresh the TabletsChannel profile in the LoadChannelMgr refresh memory statistics thread
   
   This means that `enable_profile=false` will refresh and have performance issues
   ![img_v2_a99689ae-a705-42b7-910a-b3634d8c7b7g](https://github.com/apache/doris/assets/13197424/818ce16b-3418-42dc-b0aa-dcfd78bf65ec)
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #20992: [fix](profile) avoid unnecessary refresh profile of TabletsChannel

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #20992:
URL: https://github.com/apache/doris/pull/20992#issuecomment-1598721472

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #20992: [fix](profile) avoid unnecessary refresh profile of TabletsChannel

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #20992:
URL: https://github.com/apache/doris/pull/20992#issuecomment-1598721561

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #20992: [fix](profile) avoid unnecessary refresh profile of TabletsChannel

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #20992:
URL: https://github.com/apache/doris/pull/20992#issuecomment-1597002149

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] xinyiZzz commented on pull request #20992: [fix](profile) avoid unnecessary refresh profile of TabletsChannel

Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.

xinyiZzz commented on PR #20992:
URL: https://github.com/apache/doris/pull/20992#issuecomment-1596994541

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] xinyiZzz merged pull request #20992: [fix](profile) avoid unnecessary refresh profile of TabletsChannel

Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.

xinyiZzz merged PR #20992:
URL: https://github.com/apache/doris/pull/20992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org