You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/23 17:19:07 UTC
[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #1970: Replace mirror-cn profile with Apache officially suggested dlcdn
yaooqinn opened a new pull request #1970:
URL: https://github.com/apache/incubator-kyuubi/pull/1970
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Replace `mirror-cn` profile with Apache officially suggested dlcdn.
mirror-cn is only suite for CN, while dlcdn is much wiser.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1970: Replace mirror-cn profile with Apache officially suggested dlcdn
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1970:
URL: https://github.com/apache/incubator-kyuubi/pull/1970#discussion_r813502646
##########
File path: docs/develop_tools/building.md
##########
@@ -73,22 +73,18 @@ Profile | Default | Since
-Pspark-3.1 | No | 1.1.0
-## Defining the Apache Mirror for Spark or Flink
+## Building with Apache dlcdn site
-By default, we use `https://archive.apache.org/dist/spark/` to download the built-in Spark or
-use `https://archive.apache.org/dist/flink/` to download the built-in Flink release package,
-but if you find it hard to reach, or the downloading speed is too slow, you can define the `spark.archive.mirror`
-or `flink.archive.mirror` property to a suitable Apache mirror site. For instance,
+By default, we use `https://archive.apache.org/dist/` to download the built-in release packages of engines,
+such as Spark or Flink.
+But sometimes, you may find it hard to reach, or the download speed is too slow,
+then you can define the `apache.archive.dist` by `-Pmirror-cdn` to accelerate to download speed.
+For example,
```bash
-build/mvn clean package -Dspark.archive.mirror=https://mirrors.bfsu.edu.cn/apache/spark/spark-3.0.1
+build/mvn clean package -Pmirror-cdn
```
-Visit [Apache Mirrors](http://www.apache.org/mirrors/) and choose a mirror based on your region.
-
-Specifically for developers in China mainland, you can use the pre-defined profile named `mirror-cn`
- which use `mirrors.bfsu.edu.cn` to speed up Spark Binary downloading. For instance,
-
-```bash
-build/mvn clean package -Pmirror-cn
-```
+The profile migrates your download repo to the Apache offically suggested site - https://dlcdn.apache.org.
Review comment:
` is not for links
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1970: Replace mirror-cn profile with Apache officially suggested dlcdn
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1970:
URL: https://github.com/apache/incubator-kyuubi/pull/1970#issuecomment-1049441744
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1970](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a325f82) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/770499ca544908a9755e8ac4702efb68398129c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (770499c) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1970 +/- ##
============================================
+ Coverage 60.36% 60.41% +0.05%
Complexity 69 69
============================================
Files 305 305
Lines 14859 14859
Branches 1927 1927
============================================
+ Hits 8969 8977 +8
+ Misses 5111 5105 -6
+ Partials 779 777 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.36% <0.00%> (+0.14%)` | :arrow_up: |
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `85.95% <0.00%> (+0.82%)` | :arrow_up: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `95.00% <0.00%> (+2.50%)` | :arrow_up: |
| [...i/ha/client/zookeeper/ServiceDiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC96b29rZWVwZXIvU2VydmljZURpc2NvdmVyeUNsaWVudC5zY2FsYQ==) | `62.50% <0.00%> (+3.84%)` | :arrow_up: |
| [...ache/kyuubi/ha/client/EngineServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9FbmdpbmVTZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `80.00% <0.00%> (+6.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [770499c...a325f82](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1970: Replace mirror-cn profile with Apache officially suggested dlcdn
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1970:
URL: https://github.com/apache/incubator-kyuubi/pull/1970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1970: Replace mirror-cn profile with Apache officially suggested dlcdn
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1970:
URL: https://github.com/apache/incubator-kyuubi/pull/1970#discussion_r813490849
##########
File path: docs/develop_tools/building.md
##########
@@ -73,22 +73,18 @@ Profile | Default | Since
-Pspark-3.1 | No | 1.1.0
-## Defining the Apache Mirror for Spark or Flink
+## Building with Apache dlcdn site
-By default, we use `https://archive.apache.org/dist/spark/` to download the built-in Spark or
-use `https://archive.apache.org/dist/flink/` to download the built-in Flink release package,
-but if you find it hard to reach, or the downloading speed is too slow, you can define the `spark.archive.mirror`
-or `flink.archive.mirror` property to a suitable Apache mirror site. For instance,
+By default, we use `https://archive.apache.org/dist/` to download the built-in release packages of engines,
+such as Spark or Flink.
+But sometimes, you may find it hard to reach, or the download speed is too slow,
+then you can define the `apache.archive.dist` by `-Pmirror-cdn` to accelerate to download speed.
+For example,
```bash
-build/mvn clean package -Dspark.archive.mirror=https://mirrors.bfsu.edu.cn/apache/spark/spark-3.0.1
+build/mvn clean package -Pmirror-cdn
```
-Visit [Apache Mirrors](http://www.apache.org/mirrors/) and choose a mirror based on your region.
-
-Specifically for developers in China mainland, you can use the pre-defined profile named `mirror-cn`
- which use `mirrors.bfsu.edu.cn` to speed up Spark Binary downloading. For instance,
-
-```bash
-build/mvn clean package -Pmirror-cn
-```
+The profile migrates your download repo to the Apache offically suggested site - https://dlcdn.apache.org.
Review comment:
Do we need to quote the "https://dlcdn.apache.org" by `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1970: Replace mirror-cn profile with Apache officially suggested dlcdn
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1970:
URL: https://github.com/apache/incubator-kyuubi/pull/1970#issuecomment-1049441744
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1970](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a0756b4) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/770499ca544908a9755e8ac4702efb68398129c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (770499c) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head a0756b4 differs from pull request most recent head a325f82. Consider uploading reports for the commit a325f82 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1970 +/- ##
=========================================
Coverage 60.36% 60.36%
Complexity 69 69
=========================================
Files 305 305
Lines 14859 14859
Branches 1927 1927
=========================================
Hits 8969 8969
- Misses 5111 5113 +2
+ Partials 779 777 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `61.33% <0.00%> (-1.34%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.36% <0.00%> (+0.14%)` | :arrow_up: |
| [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `85.95% <0.00%> (+0.82%)` | :arrow_up: |
| [...n/scala/org/apache/kyuubi/KyuubiSQLException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9LeXV1YmlTUUxFeGNlcHRpb24uc2NhbGE=) | `93.97% <0.00%> (+1.20%)` | :arrow_up: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `95.00% <0.00%> (+2.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [770499c...a325f82](https://codecov.io/gh/apache/incubator-kyuubi/pull/1970?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1970: Replace mirror-cn profile with Apache officially suggested dlcdn
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1970:
URL: https://github.com/apache/incubator-kyuubi/pull/1970#discussion_r813489824
##########
File path: pom.xml
##########
@@ -1810,10 +1811,10 @@
<profiles>
<profile>
- <id>mirror-cn</id>
+ <id>mirror-cdn</id>
+ <!-- this profile works only for lastest apache releases -->
Review comment:
typo: lastest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org