You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/09 12:01:15 UTC

[GitHub] yanghua commented on a change in pull request #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor

yanghua commented on a change in pull request #6876: [FLINK-10251] Handle oversized response messages in AkkaRpcActor
URL: https://github.com/apache/flink/pull/6876#discussion_r246357052
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcActor.java
 ##########
 @@ -71,7 +73,7 @@
  *
  * @param <T> Type of the {@link RpcEndpoint}
  */
-class AkkaRpcActor<T extends RpcEndpoint & RpcGateway> extends UntypedActor {
+public class AkkaRpcActor<T extends RpcEndpoint & RpcGateway> extends UntypedActor {
 
 Review comment:
   Oh, I created `org.apache.flink.runtime.rpc.TestingRemoteAkkaRpcActor` before. Now, I will move this class into pkg `org.apache.flink.runtime.rpc.akka`,  then I can remove the `public` keyword.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services