You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/12/20 10:41:57 UTC
[GitHub] [commons-fileupload] nucleussoftwareopen opened a new pull request, #188: Adding capability to take max upload size per request.
nucleussoftwareopen opened a new pull request, #188:
URL: https://github.com/apache/commons-fileupload/pull/188
As of now FileUploadBase has sizeMax which is global for all uploads, in many cases it is required to calculate this limit based on request.
https://stackoverflow.com/questions/16585866/changing-file-size-limit-maxuploadsize-depending-on-the-controller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] garydgregory commented on pull request #188: Adding capability to take max upload size per request.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #188:
URL: https://github.com/apache/commons-fileupload/pull/188#issuecomment-1359267255
-1, there should be tests along with new features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] nucleussoftwareopen commented on pull request #188: Adding capability to take max upload size per request.
Posted by GitBox <gi...@apache.org>.
nucleussoftwareopen commented on PR #188:
URL: https://github.com/apache/commons-fileupload/pull/188#issuecomment-1364029667
Hi, Thanks for sharing your thoughts & reviews.
In this PR we are introducing a new functionality which allows a user to get the allowed max size for current file upload. Also, the subclasses can override the newly introduced getSizeMaxForThisRequest() method to calculate the allowed size per request.
This will help users to provide granularity in the allowed max size for the files uploaded via different requests against different requirements/ use-cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #188: Adding capability to take max upload size per request.
Posted by GitBox <gi...@apache.org>.
jochenw commented on PR #188:
URL: https://github.com/apache/commons-fileupload/pull/188#issuecomment-1359253255
Hi, thanks for the PR. I'd like to understand, what this is about, or in other words: What is the use case?
In my opinion, if there really is a request, that needs special handling: Why not just create another controller?
Thanks,
Jochen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #188: Adding capability to take max upload size per request.
Posted by GitBox <gi...@apache.org>.
jochenw commented on PR #188:
URL: https://github.com/apache/commons-fileupload/pull/188#issuecomment-1359968998
A valid point, Gary, I'll keep that in mind. Besides: Please, rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org