You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Randgalt <gi...@git.apache.org> on 2014/07/21 01:42:18 UTC
[GitHub] curator pull request: CURATOR-121 - Modified exception handling on...
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/18
CURATOR-121 - Modified exception handling on the operation queue
Modified exception handling on the operation queue to ignore InterruptedException during shutdown. Added additional unit test for this case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-121
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 51109813ebd3104b74181be26532c3692f41bb02
Author: Cam McKenzie <ca...@apache.org>
Date: 2014-07-19T18:10:32Z
CURATOR-121 - Modified exception handling on the operation queue to
ignore InterruptedException during shutdown. Added additional unit test
for this case.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-121 - Modified exception handling on...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-121 - Modified exception handling on...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/18#discussion_r15152791
--- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/PathChildrenCache.java ---
@@ -761,6 +761,15 @@ public void run()
operationsQuantizer.remove(operation);
operation.invoke();
}
+ catch ( InterruptedException e )
+ {
+ //We expect to get interrupted during shutdown,
--- End diff --
when catching InterruptedException, the thread interrupted status must be reset via:
```java
Thread.currentThread().interrupt()
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-121 - Modified exception handling on...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/18#issuecomment-49563625
Other than my comment, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---