You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/24 01:07:39 UTC
[GitHub] [incubator-nuttx-apps] adamfeuer opened a new pull request #92:
tcpblaster reporting and documentation improvements
adamfeuer opened a new pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92
### Summary
* Improves reporting with timestamp, group count, and clarified bandwidth (changes message that incorrectly shows Kb [kilobits] to KB [kilobytes])
* Adds group configuration (was hardcoded at 50 buffers per send; this is now configurable)
* Adds README that shows how to configure and run
### Impact
* None if you don't use tcpblaster
* tcpblaster is now more configurable and has clearer reporting that allows for hang-detection on long runtimes
### Testing
* Manual on the simulator, SAMA5D3-Xplained (SAMA5D36), and Linux.
### How To Verify
* Run tcpblaster as per the README
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383073345
##########
File path: examples/tcpblaster/tcpblaster_server.c
##########
@@ -257,7 +257,7 @@ void tcpblaster_server(void)
fkbsent = (float)recvtotal / 1024.0;
felapsed = (float)elapsed.tv_sec + (float)elapsed.tv_nsec / 1000000000.0;
- printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
+ printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
Review comment:
No, it doesn't make sense to request all patches merge into one. But in one PR, if the first patch has some issue, and the second patch fix that issue(.e.g printf alignment, printf("=")), we should merge the second patch into the first one, instead make the mainline history urgly.
Each patch should work well individual without the following patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on a change in pull
request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383076662
##########
File path: examples/tcpblaster/tcpblaster_client.c
##########
@@ -166,7 +166,6 @@ void tcpblaster_client(void)
/* Wait until we can send data or until the connection is lost */
- printf("=");
Review comment:
@xiaoxiang781216 rebase against master and push -f, got it. Thanks. I will fix this tomorrow!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on a change in pull
request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383072515
##########
File path: examples/tcpblaster/tcpblaster_server.c
##########
@@ -257,7 +257,7 @@ void tcpblaster_server(void)
fkbsent = (float)recvtotal / 1024.0;
felapsed = (float)elapsed.tv_sec + (float)elapsed.tv_nsec / 1000000000.0;
- printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
+ printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
Review comment:
@xiaoxiang781216 Do you mean, squash all the commits into one so master doesn't end up with multiple commits?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on issue #92: tcpblaster
reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on issue #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#issuecomment-590648967
@xiaoxiang781216 Got it, will remove in future PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383070522
##########
File path: examples/tcpblaster/tcpblaster_server.c
##########
@@ -257,7 +257,7 @@ void tcpblaster_server(void)
fkbsent = (float)recvtotal / 1024.0;
felapsed = (float)elapsed.tv_sec + (float)elapsed.tv_nsec / 1000000000.0;
- printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
+ printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
Review comment:
Let's merge into one patch instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383070282
##########
File path: examples/tcpblaster/tcpblaster_client.c
##########
@@ -218,10 +224,13 @@ void tcpblaster_client(void)
elapsed.tv_nsec = curr.tv_nsec + borrow;
}
+ char timebuff[100];
Review comment:
Need move to variable declaration section
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383070376
##########
File path: examples/tcpblaster/tcpblaster_server.c
##########
@@ -247,13 +251,17 @@ void tcpblaster_server(void)
elapsed.tv_nsec = curr.tv_nsec + borrow;
}
+ char timebuff[100];
+ strftime (timebuff, 100, "%Y-%m-%d %H:%M:%S.000", localtime (&curr));
Review comment:
Same comment as before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on a change in pull
request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383072376
##########
File path: examples/tcpblaster/tcpblaster_client.c
##########
@@ -218,10 +224,13 @@ void tcpblaster_client(void)
elapsed.tv_nsec = curr.tv_nsec + borrow;
}
+ char timebuff[100];
+ strftime (timebuff, 100, "%Y-%m-%d %H:%M:%S.000", localtime (&curr));
Review comment:
@xiaoxiang781216 will fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on issue #92: tcpblaster
reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on issue #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#issuecomment-590627314
@xiaoxiang781216 I made the requested improvements, rebased, and force-pushed to this branch. Will you let me know if there are more improvements you'd like to see?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #92:
tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383076184
##########
File path: examples/tcpblaster/tcpblaster_client.c
##########
@@ -166,7 +166,6 @@ void tcpblaster_client(void)
/* Wait until we can send data or until the connection is lost */
- printf("=");
Review comment:
It's very easy, all is automatically with git rebase --interactive:
https://hackernoon.com/beginners-guide-to-interactive-rebasing-346a3f9c3a6d
Once your finish to refine the patchset, you can run git push with -f flag to update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on a change in pull
request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383072368
##########
File path: examples/tcpblaster/tcpblaster_client.c
##########
@@ -218,10 +224,13 @@ void tcpblaster_client(void)
elapsed.tv_nsec = curr.tv_nsec + borrow;
}
+ char timebuff[100];
Review comment:
@xiaoxiang781216 will fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on a change in pull
request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383072393
##########
File path: examples/tcpblaster/tcpblaster_server.c
##########
@@ -247,13 +251,17 @@ void tcpblaster_server(void)
elapsed.tv_nsec = curr.tv_nsec + borrow;
}
+ char timebuff[100];
+ strftime (timebuff, 100, "%Y-%m-%d %H:%M:%S.000", localtime (&curr));
+
fkbsent = (float)recvtotal / 1024.0;
felapsed = (float)elapsed.tv_sec + (float)elapsed.tv_nsec / 1000000000.0;
- printf("Received %d buffers: %7.1f Kb (avg %5.1f Kb) in %6.2f Sec (%7.1f Kb/Sec)\n",
- recvcount, fkbsent, fkbsent/recvcount, felapsed, fkbsent/felapsed);
+ printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
Review comment:
@xiaoxiang781216 will fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on a change in pull
request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383072389
##########
File path: examples/tcpblaster/tcpblaster_server.c
##########
@@ -247,13 +251,17 @@ void tcpblaster_server(void)
elapsed.tv_nsec = curr.tv_nsec + borrow;
}
+ char timebuff[100];
+ strftime (timebuff, 100, "%Y-%m-%d %H:%M:%S.000", localtime (&curr));
Review comment:
@xiaoxiang781216 will fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383070736
##########
File path: examples/tcpblaster/tcpblaster_client.c
##########
@@ -166,7 +166,6 @@ void tcpblaster_client(void)
/* Wait until we can send data or until the connection is lost */
- printf("=");
Review comment:
Modify the previous patch instead, it's better to make the patch clean if it doesn't merge into mainline yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383070314
##########
File path: examples/tcpblaster/tcpblaster_client.c
##########
@@ -218,10 +224,13 @@ void tcpblaster_client(void)
elapsed.tv_nsec = curr.tv_nsec + borrow;
}
+ char timebuff[100];
+ strftime (timebuff, 100, "%Y-%m-%d %H:%M:%S.000", localtime (&curr));
Review comment:
revmove space before (
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383070408
##########
File path: examples/tcpblaster/tcpblaster_server.c
##########
@@ -247,13 +251,17 @@ void tcpblaster_server(void)
elapsed.tv_nsec = curr.tv_nsec + borrow;
}
+ char timebuff[100];
+ strftime (timebuff, 100, "%Y-%m-%d %H:%M:%S.000", localtime (&curr));
+
fkbsent = (float)recvtotal / 1024.0;
felapsed = (float)elapsed.tv_sec + (float)elapsed.tv_nsec / 1000000000.0;
- printf("Received %d buffers: %7.1f Kb (avg %5.1f Kb) in %6.2f Sec (%7.1f Kb/Sec)\n",
- recvcount, fkbsent, fkbsent/recvcount, felapsed, fkbsent/felapsed);
+ printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
Review comment:
Remove two space before printf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on a change in pull
request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383075505
##########
File path: examples/tcpblaster/tcpblaster_server.c
##########
@@ -257,7 +257,7 @@ void tcpblaster_server(void)
fkbsent = (float)recvtotal / 1024.0;
felapsed = (float)elapsed.tv_sec + (float)elapsed.tv_nsec / 1000000000.0;
- printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
+ printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
Review comment:
@xiaoxiang781216 Ok, I'll look into how to do what you ask!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #92:
tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#issuecomment-590645412
@adamfeuer In the furture PR, it's better to remove the internal merge from the commit message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] adamfeuer commented on a change in pull
request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383075590
##########
File path: examples/tcpblaster/tcpblaster_client.c
##########
@@ -166,7 +166,6 @@ void tcpblaster_client(void)
/* Wait until we can send data or until the connection is lost */
- printf("=");
Review comment:
@xiaoxiang781216 ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #92: tcpblaster reporting and documentation improvements
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #92: tcpblaster reporting and documentation improvements
URL: https://github.com/apache/incubator-nuttx-apps/pull/92#discussion_r383076356
##########
File path: examples/tcpblaster/tcpblaster_server.c
##########
@@ -257,7 +257,7 @@ void tcpblaster_server(void)
fkbsent = (float)recvtotal / 1024.0;
felapsed = (float)elapsed.tv_sec + (float)elapsed.tv_nsec / 1000000000.0;
- printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
+ printf("[%s] %d: Received %d buffers: %7.1f KB (buffer average size: %5.1f KB) in %6.2f seconds (%7.1f KB/second)\n",
Review comment:
It's very easy, all is automatically with git rebase --interactive:
https://hackernoon.com/beginners-guide-to-interactive-rebasing-346a3f9c3a6d
Once your finish to refine the patchset, you can run git push with -f flag to update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services