[GitHub] [arrow] marsupialtail commented on a diff in pull request #13385: ARROW-16521 [C++][R] Configure curl timeout policy for S3

[GitBox <gi...@apache.org>]

marsupialtail commented on code in PR #13385:
URL: https://github.com/apache/arrow/pull/13385#discussion_r913898236


##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -701,6 +701,17 @@ class ClientBuilder {
     if (!options_.region.empty()) {
       client_config_.region = ToAwsString(options_.region);
     }
+    if (options_.request_timeout_ms != -1) {
+      client_config_.requestTimeoutMs = options_.request_timeout_ms;

Review Comment:
   On Mac, both options are needed. using connectTimeoutMs without requestTimeoutMs leads to a hang when trying to open an input file. using requestTimeoutMs without connectTimeoutMs just leads to time out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org