You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "TakaHiR07 (via GitHub)" <gi...@apache.org> on 2023/06/29 11:58:46 UTC
[GitHub] [pulsar-client-cpp] TakaHiR07 opened a new pull request, #295: [fix] producer do not create when topic update partition
TakaHiR07 opened a new pull request, #295:
URL: https://github.com/apache/pulsar-client-cpp/pull/295
### Motivation
When topic update partition, new producer is not created on the new partition. The reason is runPartitionUpdateTask not work well.
### Modifications
runPartitionUpdateTask should be executed next time when partition not updated.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `doc-not-needed`
(Please explain why)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #295: [fix] producer do not create when topic update partition
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower merged PR #295:
URL: https://github.com/apache/pulsar-client-cpp/pull/295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] liuhongtong commented on pull request #295: [fix] producer do not create when topic update partition
Posted by "liuhongtong (via GitHub)" <gi...@apache.org>.
liuhongtong commented on PR #295:
URL: https://github.com/apache/pulsar-client-cpp/pull/295#issuecomment-1614427359
nice fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] TakaHiR07 commented on pull request #295: [fix] producer do not create when topic update partition
Posted by "TakaHiR07 (via GitHub)" <gi...@apache.org>.
TakaHiR07 commented on PR #295:
URL: https://github.com/apache/pulsar-client-cpp/pull/295#issuecomment-1614077710
> It's better to add a test. The current logic is protected by https://github.com/apache/pulsar-client-cpp/blob/main/tests/PartitionsUpdateTest.cc
I have improved previous PartitionsUpdateTest to verify the problem and fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #295: [fix] producer do not create when topic update partition
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #295:
URL: https://github.com/apache/pulsar-client-cpp/pull/295#issuecomment-1614432656
It might also fix https://github.com/apache/pulsar-client-cpp/issues/50, which was closed due to no reproduce code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org