You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Tim Ellison <t....@gmail.com> on 2006/07/04 15:14:34 UTC
[tools] Finding tools helper jars (was: Re: svn commit: r418195 -
/incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java)
Geir Magnusson Jr wrote:
> Actually, what about some kind of SPI? Or now that JSR-199 in in public
> draft form, anything useful in there?
How would that help? We would still have to name the JAR that contains
those providers wouldn't we?
What do you think about simply adding all jars in jdk/lib onto the tools
launcher classpath? We would then only have to ensure there are no java
naming collisions.
(Deuce.)
Regards,
Tim
> (There's two more questions.... 40-love)
>
> geir
>
>
> Geir Magnusson Jr wrote:
>> Tim Ellison wrote:
>>> Geir Magnusson Jr wrote:
>>>> Can you get your IDE to invoke ant?
>>> Of course, but do you really want our implementation code to be closely
>>> coupled to Ant?
>> RIght now it's coupled to a specific version number from eclipse-land
>> that requires the code itself to change when they update.
>>
>>> (please answer with a question, I'm getting into the Wimbledon spirit)
>> Maybe we could use a property?
>>
>> :)
>>
>> geir
>>
>>> Regards,
>>> Tim
>>>
>>>> Tim Ellison wrote:
>>>>> Geir Magnusson Jr wrote:
>>>>>> Indeed not. Should we just use an ant filter and a property to set this?
>>>>> Does your IDE cope with this? It will require testing exclusively via
>>>>> Ant I think.
>>>>>
>>>>> Regards,
>>>>> Tim
>>>>>
>>>>>> geir
>>>>>>
>>>>>>
>>>>>> tellison@apache.org wrote:
>>>>>>> Author: tellison
>>>>>>> Date: Fri Jun 30 00:49:45 2006
>>>>>>> New Revision: 418195
>>>>>>>
>>>>>>> URL: http://svn.apache.org/viewvc?rev=418195&view=rev
>>>>>>> Log:
>>>>>>> Update compiler impl reference
>>>>>>> (should not be hardcoded like this)
>>>>>>>
>>>>>>> Modified:
>>>>>>> incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java
>>>>>>>
>>>>>>> Modified: incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java
>>>>>>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java?rev=418195&r1=418194&r2=418195&view=diff
>>>>>>> ==============================================================================
>>>>>>> --- incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java (original)
>>>>>>> +++ incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java Fri Jun 30 00:49:45 2006
>>>>>>> @@ -36,7 +36,7 @@
>>>>>>> "ISO8859_1");
>>>>>>>
>>>>>>> /* FIXME: Hard-coded for now, the name of the ECJ JAR file */
>>>>>>> - static final String ECJ_JAR_FILE = "ecj_3.2RC5.jar";
>>>>>>> + static final String ECJ_JAR_FILE = "ecj_3.2MAINT.jar";
>>>>>>>
>>>>>>> /* The name of the ECJ compiler class */
>>>>>>> static final String MAIN_CLASS_NAME = "org.eclipse.jdt.internal.compiler.batch.Main";
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>>
>>>>>>
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>
>>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [tools] Finding tools helper jars
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Tim Ellison wrote:
> Geir Magnusson Jr wrote:
>> Actually, what about some kind of SPI? Or now that JSR-199 in in public
>> draft form, anything useful in there?
>
> How would that help? We would still have to name the JAR that contains
> those providers wouldn't we?
No - the tool would examine whatever jars it had in classpath looking
for META-INF/services entries, and use the class listed in there.
>
> What do you think about simply adding all jars in jdk/lib onto the tools
> launcher classpath? We would then only have to ensure there are no java
> naming collisions.
That would work, coupled with the services approach above, so we
wouldn't be hard-wired to a package+class - we'd define the key (say
"org.apache.harmony.tool.javac" or something)
I think then we avoid the ever-risky "rename the jar to get it to work"
(I tend to simply just confuse myself) and we open the door for other
compiler implementations to work with our tooling by just supporting our
services entry and then being able to be dropped right in. We can do
the same approach for the other tools as well, mapping tool name to key :
javac -> org.apache.harmony.tool.javac
javadoc -> o.a.h.t.javadoc
etc...
Do you see any pitfalls?
>
> (Deuce.)
(Advantage, geir.)
(I wish I wasn't hanging from my gables replaces outside spotlights,
trimming shrubs and hanging drapes today, but rather be celebrating our
freedom from England by watching English tennis....)
geir
>
> Regards,
> Tim
>
>> (There's two more questions.... 40-love)
>>
>> geir
>>
>>
>> Geir Magnusson Jr wrote:
>>> Tim Ellison wrote:
>>>> Geir Magnusson Jr wrote:
>>>>> Can you get your IDE to invoke ant?
>>>> Of course, but do you really want our implementation code to be closely
>>>> coupled to Ant?
>>> RIght now it's coupled to a specific version number from eclipse-land
>>> that requires the code itself to change when they update.
>>>
>>>> (please answer with a question, I'm getting into the Wimbledon spirit)
>>> Maybe we could use a property?
>>>
>>> :)
>>>
>>> geir
>>>
>>>> Regards,
>>>> Tim
>>>>
>>>>> Tim Ellison wrote:
>>>>>> Geir Magnusson Jr wrote:
>>>>>>> Indeed not. Should we just use an ant filter and a property to set this?
>>>>>> Does your IDE cope with this? It will require testing exclusively via
>>>>>> Ant I think.
>>>>>>
>>>>>> Regards,
>>>>>> Tim
>>>>>>
>>>>>>> geir
>>>>>>>
>>>>>>>
>>>>>>> tellison@apache.org wrote:
>>>>>>>> Author: tellison
>>>>>>>> Date: Fri Jun 30 00:49:45 2006
>>>>>>>> New Revision: 418195
>>>>>>>>
>>>>>>>> URL: http://svn.apache.org/viewvc?rev=418195&view=rev
>>>>>>>> Log:
>>>>>>>> Update compiler impl reference
>>>>>>>> (should not be hardcoded like this)
>>>>>>>>
>>>>>>>> Modified:
>>>>>>>> incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java
>>>>>>>>
>>>>>>>> Modified: incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java
>>>>>>>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java?rev=418195&r1=418194&r2=418195&view=diff
>>>>>>>> ==============================================================================
>>>>>>>> --- incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java (original)
>>>>>>>> +++ incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java Fri Jun 30 00:49:45 2006
>>>>>>>> @@ -36,7 +36,7 @@
>>>>>>>> "ISO8859_1");
>>>>>>>>
>>>>>>>> /* FIXME: Hard-coded for now, the name of the ECJ JAR file */
>>>>>>>> - static final String ECJ_JAR_FILE = "ecj_3.2RC5.jar";
>>>>>>>> + static final String ECJ_JAR_FILE = "ecj_3.2MAINT.jar";
>>>>>>>>
>>>>>>>> /* The name of the ECJ compiler class */
>>>>>>>> static final String MAIN_CLASS_NAME = "org.eclipse.jdt.internal.compiler.batch.Main";
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>>>
>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>
>>>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org