You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by jk...@apache.org on 2017/02/09 15:04:32 UTC

thrift git commit: THRIFT-4073: enum files are still being generated with unused imports Client: Java Patch: BCG

Repository: thrift
Updated Branches:
  refs/heads/master d1482fe3e -> f53505857


THRIFT-4073: enum files are still being generated with unused imports
Client: Java
Patch: BCG <bg...@users.noreply.github.com>

This closes #1182


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/f5350585
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/f5350585
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/f5350585

Branch: refs/heads/master
Commit: f5350585721aad1f89c0516c8db0743e3456712d
Parents: d1482fe
Author: James E. King, III <jk...@apache.org>
Authored: Thu Feb 9 10:03:03 2017 -0500
Committer: James E. King, III <jk...@apache.org>
Committed: Thu Feb 9 10:03:03 2017 -0500

----------------------------------------------------------------------
 compiler/cpp/src/thrift/generate/t_java_generator.cc | 4 ----
 1 file changed, 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/thrift/blob/f5350585/compiler/cpp/src/thrift/generate/t_java_generator.cc
----------------------------------------------------------------------
diff --git a/compiler/cpp/src/thrift/generate/t_java_generator.cc b/compiler/cpp/src/thrift/generate/t_java_generator.cc
index fb581e4..b732631 100644
--- a/compiler/cpp/src/thrift/generate/t_java_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_java_generator.cc
@@ -445,10 +445,6 @@ void t_java_generator::generate_enum(t_enum* tenum) {
   // Comment and package it
   f_enum << autogen_comment() << java_package() << endl;
 
-  // Add java imports
-  f_enum << string() + "import java.util.Map;\n" + "import java.util.HashMap;\n"
-            + "import org.apache.thrift.TEnum;" << endl << endl;
-
   generate_java_doc(f_enum, tenum);
   if (is_deprecated) {
     indent(f_enum) << "@Deprecated" << endl;