You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "colvinco (via GitHub)" <gi...@apache.org> on 2023/02/01 10:54:35 UTC
[GitHub] [solr] colvinco opened a new pull request, #1322: SOLR-16641 - Generate gradle.properties from template
colvinco opened a new pull request, #1322:
URL: https://github.com/apache/solr/pull/1322
This is a duplicate of #1320 atm, I just want to test the crave.io check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1322: SOLR-16641 - Generate gradle.properties from template
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #1322:
URL: https://github.com/apache/solr/pull/1322#discussion_r1093312163
##########
gradlew:
##########
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+# Generate gradle.properties if they don't exist
if [ ! -e "$APP_HOME/gradle.properties" ]; then
- GRADLE_DAEMON_CTRL=--no-daemon
+ echo "Populating gradle.properties from gradle.properties.template."
+ # Do the copy first. If the next steps fail, the gradle.properties will still be usable
+ cp gradle.properties.template gradle.properties
Review Comment:
Should this be absolute path?
```suggestion
cp gradle.properties.template "$APP_HOME/gradle.properties"
```
##########
gradlew:
##########
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+# Generate gradle.properties if they don't exist
if [ ! -e "$APP_HOME/gradle.properties" ]; then
- GRADLE_DAEMON_CTRL=--no-daemon
+ echo "Populating gradle.properties from gradle.properties.template."
+ # Do the copy first. If the next steps fail, the gradle.properties will still be usable
+ cp gradle.properties.template gradle.properties
+ NUM_CORES=$(grep ^cpu\\scores /proc/cpuinfo | uniq | awk '{print $4}')
Review Comment:
`/proc/cpuinfo` won't work on macOS. Either detect OS and handle it specifically, or fall back to some decent default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1322: SOLR-16641 - Generate gradle.properties from template
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1322:
URL: https://github.com/apache/solr/pull/1322#issuecomment-1412177554
Sorry for adding the review here instead of #1320, it was a mistake. I can add it there if you want, or I'll wait a few days to see how that PR evolves and review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] colvinco commented on pull request #1322: SOLR-16641 - Generate gradle.properties from template
Posted by "colvinco (via GitHub)" <gi...@apache.org>.
colvinco commented on PR #1322:
URL: https://github.com/apache/solr/pull/1322#issuecomment-1412415473
Sorry, I'll close this one but I'll remember the comments on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] colvinco closed pull request #1322: SOLR-16641 - Generate gradle.properties from template
Posted by "colvinco (via GitHub)" <gi...@apache.org>.
colvinco closed pull request #1322: SOLR-16641 - Generate gradle.properties from template
URL: https://github.com/apache/solr/pull/1322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org