You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/12/20 02:30:53 UTC

[GitHub] [trafficserver] zwoop opened a new pull request, #9263: This adds a simple (static) metric for counting cache spans

zwoop opened a new pull request, #9263:
URL: https://github.com/apache/trafficserver/pull/9263

   With this patch, we get metrics like
   
   proxy.process.cache.spans 4
   proxy.process.cache.volume_0.spans 2
   proxy.process.cache.volume_1.spans 2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bryancall commented on pull request #9263: This adds a simple (static) metric for counting cache spans

Posted by GitBox <gi...@apache.org>.
bryancall commented on PR #9263:
URL: https://github.com/apache/trafficserver/pull/9263#issuecomment-1376543743

   @zwoop Can you please address @SolidWallOfCode comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] zwoop commented on pull request #9263: This adds a simple (static) metric for counting cache stripes

Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #9263:
URL: https://github.com/apache/trafficserver/pull/9263#issuecomment-1386090349

   [approve ci autest 2]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] zwoop commented on pull request #9263: This adds a simple (static) metric for counting cache stripes

Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #9263:
URL: https://github.com/apache/trafficserver/pull/9263#issuecomment-1382187441

   > Would it not be simpler to copy the value for `gnvol` instead of independently computing the value? I'm not happy with "spans", either, since those are called "stripes" in the documentation.
   
   I changed all "spans" to "stripes".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] ezelkow1 commented on pull request #9263: This adds a simple (static) metric for counting cache spans

Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on PR #9263:
URL: https://github.com/apache/trafficserver/pull/9263#issuecomment-1360044525

   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9263: This adds a simple (static) metric for counting cache spans

Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on PR #9263:
URL: https://github.com/apache/trafficserver/pull/9263#issuecomment-1365509593

   Would it not be simpler to copy the value for `gnvol` instead of independently computing the value? I'm not happy with "spans", either, since those are called "stripes" in the documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] zwoop merged pull request #9263: This adds a simple (static) metric for counting cache stripes

Posted by GitBox <gi...@apache.org>.
zwoop merged PR #9263:
URL: https://github.com/apache/trafficserver/pull/9263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] zwoop commented on pull request #9263: This adds a simple (static) metric for counting cache stripes

Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #9263:
URL: https://github.com/apache/trafficserver/pull/9263#issuecomment-1385713544

   [approve ci autest]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org