[incubator-pinot] branch master updated: Fix a typo and javadoc in SegmentCreationJob (#3825)

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 4650440  Fix a typo and javadoc in SegmentCreationJob (#3825)
4650440 is described below

commit 465044006f66d3d0e9df0c7e9726910651d21bd6
Author: Xiaotian (Jackie) Jiang <17...@users.noreply.github.com>
AuthorDate: Wed Feb 13 10:20:35 2019 -0800

    Fix a typo and javadoc in SegmentCreationJob (#3825)
---
 .../java/org/apache/pinot/hadoop/job/SegmentCreationJob.java     | 9 ++++++---
 .../apache/pinot/hadoop/job/mapper/SegmentCreationMapper.java    | 2 +-
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java b/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java
index 7876563..f077197 100644
--- a/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java
+++ b/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java
@@ -233,7 +233,10 @@ public class SegmentCreationJob extends BaseSegmentJob {
     }
   }
 
-  protected DefaultControllerRestApi getControllerRestApi() {
+  /**
+   * Can be overridden to provide custom controller Rest API.
+   */
+  protected ControllerRestApi getControllerRestApi() {
     return new DefaultControllerRestApi(_pushLocations, _rawTableName);
   }
 
@@ -248,7 +251,7 @@ public class SegmentCreationJob extends BaseSegmentJob {
   }
 
   /**
-   * Can be override to plug in custom mapper.
+   * Can be overridden to plug in custom mapper.
    */
   protected Class<? extends Mapper<LongWritable, Text, LongWritable, Text>> getMapperClass() {
     return SegmentCreationMapper.class;
@@ -278,7 +281,7 @@ public class SegmentCreationJob extends BaseSegmentJob {
   }
 
   /**
-   * Can be override to set additional job properties.
+   * Can be overridden to set additional job properties.
    */
   @SuppressWarnings("unused")
   protected void addAdditionalJobProperties(Job job) {
diff --git a/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mapper/SegmentCreationMapper.java b/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mapper/SegmentCreationMapper.java
index e8a122d..a07ecf5 100644
--- a/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mapper/SegmentCreationMapper.java
+++ b/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mapper/SegmentCreationMapper.java
@@ -233,7 +233,7 @@ public class SegmentCreationMapper extends Mapper<LongWritable, Text, LongWritab
   }
 
   /**
-   * Can be override to set additional segment generator configs.
+   * Can be overridden to set additional segment generator configs.
    */
   @SuppressWarnings("unused")
   protected void addAdditionalSegmentGeneratorConfigs(SegmentGeneratorConfig segmentGeneratorConfig, Path hdfsInputFile,


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org