[GitHub] [pulsar] Technoboy- commented on a change in pull request #14367: [Issue 14362] Fix Broker HealthCheck Endpoint Exposes Race Conditions

[GitBox <gi...@apache.org>]

Technoboy- commented on a change in pull request #14367:
URL: https://github.com/apache/pulsar/pull/14367#discussion_r809730770



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
##########
@@ -350,12 +347,6 @@ public void healthCheck(@Suspended AsyncResponse asyncResponse,
                                 clientAppId(), topicName);
                         throw new RestException(Status.NOT_FOUND, "Topic [{}] not found after create.");
                     }
-                    Topic topic = topicOptional.get();
-                    // clean all subscriptions
-                    return FutureUtil.waitForAll(topic.getSubscriptions().values()
-                            .stream().map(Subscription::deleteForcefully).collect(Collectors.toList()))

Review comment:
       Moving this logic to the end of the `produce-consumer`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org