You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Geertjan Wielenga <ge...@googlemail.com> on 2017/10/11 10:28:35 UTC
Who is asfgit?
Hi all,
Someone appears to automatically (I guess a bot) be merging PRs after a
couple of days of inactivity, i.e., if there are no comments etc, such as
this one of mine:
https://github.com/apache/incubator-netbeans/pull/103
Is that correct and what we want? I.e., nobody reviewed the above nor asked
any kind of questions about it.
Gj
Re: Who is asfgit?
Posted by Greg Trasuk <tr...@stratuscom.com>.
If you merge with —no-ff, it prevents a “fast-forward” commit, and creates a merge commit, where you can add a commit comment and the identity of the person doing the merge will be recorded.
It may be possible to setup automatic rejection of fast-forward commits in the ASF repository. Check with Infra.
Cheers,
Greg Trasuk
> On Oct 11, 2017, at 6:39 AM, Geertjan Wielenga <ge...@googlemail.com> wrote:
>
> Excellent! That's a relief. :-)
>
> But it would be good if we could see who did the merge, is there a way to
> see that.
>
> Gj
>
> On Wed, Oct 11, 2017 at 11:38 AM, Matthias Bläsing <
> mblaesing@doppel-helix.eu> wrote:
>
>> Hey,
>>
>> asfgit is a bot, that synchronizes the github and Apache git repositories.
>>
>> There was no automatic merge, I merged your changes, if I saw no problem.
>> For problematic changes I added a comment to the PR and die not merge
>>
>> Greetings
>>
>> Matthias
>>
>>
>>
>> Am 11. Oktober 2017 12:28:35 MESZ schrieb Geertjan Wielenga <
>> geertjan.wielenga@googlemail.com>:
>>> Hi all,
>>>
>>> Someone appears to automatically (I guess a bot) be merging PRs after a
>>> couple of days of inactivity, i.e., if there are no comments etc, such
>>> as
>>> this one of mine:
>>>
>>> https://github.com/apache/incubator-netbeans/pull/103
>>>
>>> Is that correct and what we want? I.e., nobody reviewed the above nor
>>> asked
>>> any kind of questions about it.
>>>
>>> Gj
>>
>> --
>> Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail
>> gesendet.
Re: Who is asfgit?
Posted by Geertjan Wielenga <ge...@googlemail.com>.
Excellent! That's a relief. :-)
But it would be good if we could see who did the merge, is there a way to
see that.
Gj
On Wed, Oct 11, 2017 at 11:38 AM, Matthias Bläsing <
mblaesing@doppel-helix.eu> wrote:
> Hey,
>
> asfgit is a bot, that synchronizes the github and Apache git repositories.
>
> There was no automatic merge, I merged your changes, if I saw no problem.
> For problematic changes I added a comment to the PR and die not merge
>
> Greetings
>
> Matthias
>
>
>
> Am 11. Oktober 2017 12:28:35 MESZ schrieb Geertjan Wielenga <
> geertjan.wielenga@googlemail.com>:
> >Hi all,
> >
> >Someone appears to automatically (I guess a bot) be merging PRs after a
> >couple of days of inactivity, i.e., if there are no comments etc, such
> >as
> >this one of mine:
> >
> >https://github.com/apache/incubator-netbeans/pull/103
> >
> >Is that correct and what we want? I.e., nobody reviewed the above nor
> >asked
> >any kind of questions about it.
> >
> >Gj
>
> --
> Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail
> gesendet.
Re: Who is asfgit?
Posted by Wade Chandler <wa...@apache.org>.
Does the Apache process allow merge from the PR itself on the GH side? If
so, that seems a better approach to me. Too, considering a PR, from a
submitters POV is generally an atomic operation, the logic in the PR should
be addressed then merged as a whole. It would keep magic PR closing from
happening when not expected. Too, it will limit folks missing messages in
the PR.
Thanks
Wade
On Oct 11, 2017 06:38, "Matthias Bläsing" <mb...@doppel-helix.eu> wrote:
> Hey,
>
> asfgit is a bot, that synchronizes the github and Apache git repositories.
>
> There was no automatic merge, I merged your changes, if I saw no problem.
> For problematic changes I added a comment to the PR and die not merge
>
> Greetings
>
> Matthias
>
>
>
> Am 11. Oktober 2017 12:28:35 MESZ schrieb Geertjan Wielenga <
> geertjan.wielenga@googlemail.com>:
> >Hi all,
> >
> >Someone appears to automatically (I guess a bot) be merging PRs after a
> >couple of days of inactivity, i.e., if there are no comments etc, such
> >as
> >this one of mine:
> >
> >https://github.com/apache/incubator-netbeans/pull/103
> >
> >Is that correct and what we want? I.e., nobody reviewed the above nor
> >asked
> >any kind of questions about it.
> >
> >Gj
>
> --
> Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail
> gesendet.
Re: Who is asfgit?
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hey,
asfgit is a bot, that synchronizes the github and Apache git repositories.
There was no automatic merge, I merged your changes, if I saw no problem. For problematic changes I added a comment to the PR and die not merge
Greetings
Matthias
Am 11. Oktober 2017 12:28:35 MESZ schrieb Geertjan Wielenga <ge...@googlemail.com>:
>Hi all,
>
>Someone appears to automatically (I guess a bot) be merging PRs after a
>couple of days of inactivity, i.e., if there are no comments etc, such
>as
>this one of mine:
>
>https://github.com/apache/incubator-netbeans/pull/103
>
>Is that correct and what we want? I.e., nobody reviewed the above nor
>asked
>any kind of questions about it.
>
>Gj
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.
Re: Who is asfgit?
Posted by Geertjan Wielenga <ge...@googlemail.com>.
But I did the same with this one:
https://github.com/apache/incubator-netbeans/pull/104
The only difference between that and
https://github.com/apache/incubator-netbeans/pull/103 is that 104 has a
comment, while 103 was uncommented on.
Aside from that, does this mean that we should not be committing to master
but to a development branch where someone reviews a PR before accepting it
into master?
Gj
On Wed, Oct 11, 2017 at 11:34 AM, Daniel Gruno <hu...@apache.org> wrote:
> On 10/11/2017 12:31 PM, Geertjan Wielenga wrote:
> > OK, so I did a PR (https://github.com/apache/incubator-netbeans/pull/103
> ),
> > expecting it to be reviewed before someone would manually merge it.
> >
> > AFAIK, I never merged it myself, I only created a PR. How come was it
> > merged?
>
> https://github.com/apache/incubator-netbeans/commit/
> ed4c03cb13928b6a076f4eac2730704ae2f66a82
> says you committed it to master on the netbeans repo. that counts as
> closing the PR, as far as GitHub is concerned.
> >
> > Gj
> >
> > On Wed, Oct 11, 2017 at 11:29 AM, Daniel Gruno <hu...@apache.org>
> wrote:
> >
> >> On 10/11/2017 12:28 PM, Geertjan Wielenga wrote:
> >>> Hi all,
> >>>
> >>> Someone appears to automatically (I guess a bot) be merging PRs after a
> >>> couple of days of inactivity, i.e., if there are no comments etc, such
> as
> >>> this one of mine:
> >>>
> >>> https://github.com/apache/incubator-netbeans/pull/103
> >>>
> >>> Is that correct and what we want? I.e., nobody reviewed the above nor
> >> asked
> >>> any kind of questions about it.
> >>>
> >>> Gj
> >>>
> >>
> >> asfgit is the synchronization user for the ASF on GitHub.
> >> If you merge code related to a PR, then asfgit gets put as the user
> >> closing the PR or Issue.
> >>
> >>
> >
>
>
Re: Who is asfgit?
Posted by Daniel Gruno <hu...@apache.org>.
On 10/11/2017 12:31 PM, Geertjan Wielenga wrote:
> OK, so I did a PR (https://github.com/apache/incubator-netbeans/pull/103),
> expecting it to be reviewed before someone would manually merge it.
>
> AFAIK, I never merged it myself, I only created a PR. How come was it
> merged?
https://github.com/apache/incubator-netbeans/commit/ed4c03cb13928b6a076f4eac2730704ae2f66a82
says you committed it to master on the netbeans repo. that counts as
closing the PR, as far as GitHub is concerned.
>
> Gj
>
> On Wed, Oct 11, 2017 at 11:29 AM, Daniel Gruno <hu...@apache.org> wrote:
>
>> On 10/11/2017 12:28 PM, Geertjan Wielenga wrote:
>>> Hi all,
>>>
>>> Someone appears to automatically (I guess a bot) be merging PRs after a
>>> couple of days of inactivity, i.e., if there are no comments etc, such as
>>> this one of mine:
>>>
>>> https://github.com/apache/incubator-netbeans/pull/103
>>>
>>> Is that correct and what we want? I.e., nobody reviewed the above nor
>> asked
>>> any kind of questions about it.
>>>
>>> Gj
>>>
>>
>> asfgit is the synchronization user for the ASF on GitHub.
>> If you merge code related to a PR, then asfgit gets put as the user
>> closing the PR or Issue.
>>
>>
>
Re: Who is asfgit?
Posted by Geertjan Wielenga <ge...@googlemail.com>.
OK, so I did a PR (https://github.com/apache/incubator-netbeans/pull/103),
expecting it to be reviewed before someone would manually merge it.
AFAIK, I never merged it myself, I only created a PR. How come was it
merged?
Gj
On Wed, Oct 11, 2017 at 11:29 AM, Daniel Gruno <hu...@apache.org> wrote:
> On 10/11/2017 12:28 PM, Geertjan Wielenga wrote:
> > Hi all,
> >
> > Someone appears to automatically (I guess a bot) be merging PRs after a
> > couple of days of inactivity, i.e., if there are no comments etc, such as
> > this one of mine:
> >
> > https://github.com/apache/incubator-netbeans/pull/103
> >
> > Is that correct and what we want? I.e., nobody reviewed the above nor
> asked
> > any kind of questions about it.
> >
> > Gj
> >
>
> asfgit is the synchronization user for the ASF on GitHub.
> If you merge code related to a PR, then asfgit gets put as the user
> closing the PR or Issue.
>
>
Re: Who is asfgit?
Posted by Daniel Gruno <hu...@apache.org>.
On 10/11/2017 12:28 PM, Geertjan Wielenga wrote:
> Hi all,
>
> Someone appears to automatically (I guess a bot) be merging PRs after a
> couple of days of inactivity, i.e., if there are no comments etc, such as
> this one of mine:
>
> https://github.com/apache/incubator-netbeans/pull/103
>
> Is that correct and what we want? I.e., nobody reviewed the above nor asked
> any kind of questions about it.
>
> Gj
>
asfgit is the synchronization user for the ASF on GitHub.
If you merge code related to a PR, then asfgit gets put as the user
closing the PR or Issue.