[GitHub] [shardingsphere] taojintianxia opened a new issue, #20253: Refactor the transaction IT to merge the JDBCContainer and ProxyContainer

[GitBox <gi...@apache.org>]

taojintianxia opened a new issue, #20253:
URL: https://github.com/apache/shardingsphere/issues/20253

   currently the container management code in transaction are like followings :
   
   ```java
       private final ShardingSphereProxyClusterContainer proxyContainer;
       
       private final ShardingSphereJDBCContainer jdbcContainer;
       
       private final DockerStorageContainer storageContainer;
       
       public DockerComposedContainer(final TransactionParameterized parameterized) {
           this.databaseType = parameterized.getDatabaseType();
           governanceContainer = getContainers().registerContainer(new ZookeeperContainer());
           storageContainer = getContainers().registerContainer((DockerStorageContainer) 
   
           if (TransactionTestConstants.PROXY.equalsIgnoreCase(parameterized.getAdapter())) {
               jdbcContainer = null;
               proxyContainer = (ShardingSphereProxyClusterContainer) AdapterContainerFactory.newInstance();
               proxyContainer.dependsOn(governanceContainer, storageContainer);
               getContainers().registerContainer(proxyContainer);
           } else {
               proxyContainer = null;
               ShardingSphereJDBCContainer jdbcContainer = new ShardingSphereJDBCContainer();
               this.jdbcContainer = getContainers().registerContainer(jdbcContainer);
           }
       }
   ```
   
   the proxyContainer and jdbcConainer should not seperate, there should be a `AdapterContainer` and initialized by configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia closed issue #20253: Refactor the transaction IT to merge the JDBCContainer and ProxyContainer

[GitBox <gi...@apache.org>]

taojintianxia closed issue #20253: Refactor the transaction IT to merge the JDBCContainer and ProxyContainer
URL: https://github.com/apache/shardingsphere/issues/20253


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia commented on issue #20253: Refactor the transaction IT to merge the JDBCContainer and ProxyContainer

[GitBox <gi...@apache.org>]

taojintianxia commented on issue #20253:
URL: https://github.com/apache/shardingsphere/issues/20253#issuecomment-1218913450

   please assign to me and add lable `test` and `refactor`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org