[GitHub] [incubator-devlake] likyh commented on pull request #2898: feat: replace specific vars in connection with an object.

[GitBox <gi...@apache.org>]

likyh commented on PR #2898:
URL: https://github.com/apache/incubator-devlake/pull/2898#issuecomment-1232665029

   > @likyh This current Connection Form is a controlled form design of specific Connection Properties. You are destroying nicely designed state variables so you can stuff state in to a Configuration Object meant for reading the Plugin Config? This is not the way, I am going to decline this PR. There is nothing wrong with the state props and setters designed for managing the connection form. If there is a need to consolidate these props into one object at a later time I will do so.
   
   So If we would add a new input on connection pages, we must find all of the usages and pass them on several levels of components. I don't think it a good way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org