You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/13 03:00:41 UTC
[GitHub] [apisix-ingress-controller] fgksgf opened a new pull request #679: Remove volumeMounts when webhook is disabled
fgksgf opened a new pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
___
### Bugfix
- Description
- How to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#issuecomment-917797537
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#679](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30e608b) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1e1be7401ba3707ba660a7d61df5118fc5725eff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e1be74) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 35.04% 35.04%
=======================================
Files 60 60
Lines 5967 5967
=======================================
Hits 2091 2091
Misses 3625 3625
Partials 251 251
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `63.26% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e1be74...30e608b](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fgksgf commented on a change in pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#discussion_r708217118
##########
File path: pkg/apisix/schema.go
##########
@@ -63,7 +63,7 @@ func (sc schemaClient) getSchema(ctx context.Context, name string) (*v1.Schema,
)
}
- url := sc.url + "/" + name
+ url := sc.url + name
Review comment:
It's not suitable to use `path.Join`:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#issuecomment-917797537
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#679](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c48cad) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1e1be7401ba3707ba660a7d61df5118fc5725eff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e1be74) will **not change** coverage.
> The diff coverage is `100.00%`.
> :exclamation: Current head 9c48cad differs from pull request most recent head 24e27a1. Consider uploading reports for the commit 24e27a1 to get more accurate results
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 35.04% 35.04%
=======================================
Files 60 60
Lines 5967 5967
=======================================
Hits 2091 2091
Misses 3625 3625
Partials 251 251
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `63.26% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e1be74...24e27a1](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fgksgf commented on a change in pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#discussion_r707273621
##########
File path: pkg/apisix/schema.go
##########
@@ -63,7 +63,7 @@ func (sc schemaClient) getSchema(ctx context.Context, name string) (*v1.Schema,
)
}
- url := sc.url + "/" + name
+ url := sc.url + name
Review comment:
Because I checked logs of E2E test and found there is a duplicated `/`:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#issuecomment-917797537
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#679](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35ad3b9) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1e1be7401ba3707ba660a7d61df5118fc5725eff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e1be74) will **not change** coverage.
> The diff coverage is `100.00%`.
> :exclamation: Current head 35ad3b9 differs from pull request most recent head 60cca93. Consider uploading reports for the commit 60cca93 to get more accurate results
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 35.04% 35.04%
=======================================
Files 60 60
Lines 5967 5967
=======================================
Hits 2091 2091
Misses 3625 3625
Partials 251 251
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `63.26% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e1be74...60cca93](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#issuecomment-917797537
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#679](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb255cc) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1e1be7401ba3707ba660a7d61df5118fc5725eff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e1be74) will **increase** coverage by `0.33%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 35.04% 35.37% +0.33%
==========================================
Files 60 60
Lines 5967 5967
==========================================
+ Hits 2091 2111 +20
+ Misses 3625 3612 -13
+ Partials 251 244 -7
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `63.26% <100.00%> (ø)` | |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `37.76% <0.00%> (+2.09%)` | :arrow_up: |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.75% <0.00%> (+3.50%)` | :arrow_up: |
| [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `100.00% <0.00%> (+20.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e1be74...bb255cc](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#issuecomment-917797537
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#679](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1e395e) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1e1be7401ba3707ba660a7d61df5118fc5725eff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e1be74) will **increase** coverage by `0.33%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 35.04% 35.37% +0.33%
==========================================
Files 60 60
Lines 5967 5967
==========================================
+ Hits 2091 2111 +20
+ Misses 3625 3612 -13
+ Partials 251 244 -7
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `63.26% <100.00%> (ø)` | |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `37.76% <0.00%> (+2.09%)` | :arrow_up: |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.75% <0.00%> (+3.50%)` | :arrow_up: |
| [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `100.00% <0.00%> (+20.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e1be74...f1e395e](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#issuecomment-917797537
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#679](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e721140) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1e1be7401ba3707ba660a7d61df5118fc5725eff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e1be74) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 35.04% 35.04%
=======================================
Files 60 60
Lines 5967 5967
=======================================
Hits 2091 2091
Misses 3625 3625
Partials 251 251
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e1be74...e721140](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fgksgf commented on a change in pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#discussion_r707326220
##########
File path: test/e2e/ingress/webhook.go
##########
@@ -24,7 +24,7 @@ import (
"github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
)
-var _ = ginkgo.Describe("Enable webhooks", func() {
+var _ = ginkgo.FDescribe("Enable webhooks", func() {
Review comment:
OK, I'm debugging the webhook test case.
##########
File path: pkg/apisix/schema.go
##########
@@ -63,7 +63,7 @@ func (sc schemaClient) getSchema(ctx context.Context, name string) (*v1.Schema,
)
}
- url := sc.url + "/" + name
+ url := sc.url + name
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fgksgf commented on a change in pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#discussion_r708221014
##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -276,10 +276,7 @@ spec:
- --apisix-route-version
- %s
- --watch-endpointslices
- volumeMounts:
- - name: webhook-certs
- mountPath: /etc/webhook/certs
- readOnly: true
+ %s
volumes:
- name: webhook-certs
Review comment:
It doesn't seem to affect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#discussion_r707324692
##########
File path: test/e2e/ingress/webhook.go
##########
@@ -24,7 +24,7 @@ import (
"github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
)
-var _ = ginkgo.Describe("Enable webhooks", func() {
+var _ = ginkgo.FDescribe("Enable webhooks", func() {
Review comment:
Please don't forget to revert his change before this PR merged.
##########
File path: pkg/apisix/schema.go
##########
@@ -63,7 +63,7 @@ func (sc schemaClient) getSchema(ctx context.Context, name string) (*v1.Schema,
)
}
- url := sc.url + "/" + name
+ url := sc.url + name
Review comment:
OK, use `path.Join` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#discussion_r707238227
##########
File path: pkg/apisix/schema.go
##########
@@ -63,7 +63,7 @@ func (sc schemaClient) getSchema(ctx context.Context, name string) (*v1.Schema,
)
}
- url := sc.url + "/" + name
+ url := sc.url + name
Review comment:
Why change this? Maybe path.Join is more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#discussion_r706975140
##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -276,10 +276,7 @@ spec:
- --apisix-route-version
- %s
- --watch-endpointslices
- volumeMounts:
- - name: webhook-certs
- mountPath: /etc/webhook/certs
- readOnly: true
+ %s
volumes:
- name: webhook-certs
Review comment:
Should this also be set only when enableWebhook=true ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #679: Remove volumeMounts when webhook is disabled
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#issuecomment-917797537
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#679](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b64ae5b) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/1e1be7401ba3707ba660a7d61df5118fc5725eff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e1be74) will **not change** coverage.
> The diff coverage is `100.00%`.
> :exclamation: Current head b64ae5b differs from pull request most recent head 7801245. Consider uploading reports for the commit 7801245 to get more accurate results
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 35.04% 35.04%
=======================================
Files 60 60
Lines 5967 5967
=======================================
Hits 2091 2091
Misses 3625 3625
Partials 251 251
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `63.26% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e1be74...7801245](https://codecov.io/gh/apache/apisix-ingress-controller/pull/679?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org