[GitHub] [ozone] adoroszlai commented on a diff in pull request #4278: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on code in PR #4278:
URL: https://github.com/apache/ozone/pull/4278#discussion_r1107038004


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -802,7 +802,7 @@ public static final class Port {
      */
     public enum Name {
       STANDALONE, RATIS, REST, REPLICATION, RATIS_ADMIN, RATIS_SERVER,
-      RATIS_DATASTREAM;
+      RATIS_DATASTREAM, HTTP_PORT, HTTPS_PORT;

Review Comment:
   Please rename to `HTTP` and `HTTPS`.  None of the other names include "_PORT".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org