[GitHub] leventov opened a new pull request #6400: Optimize data structures in SelectResultValueBuilder

[GitBox <gi...@apache.org>]

leventov opened a new pull request #6400: Optimize data structures in SelectResultValueBuilder
URL: https://github.com/apache/incubator-druid/pull/6400
 
 
   `MinMaxPriorityQueue` is never needed. Also, when there is no threshold of the number of results, it's practically faster better to aggregate results in an `ArrayList` from the beginning and then sort in the end, than aggregate in a priority queue (because quick sort is considered faster than heap sort).
   
   Also, I don't understand the meaning of `pagingIdentifiers` - it's not explained anywhere. Is it important for this Map to put entries in order?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org