You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <o....@dplanet.ch> on 2003/02/26 22:25:09 UTC
[PATCH] 'expect: 100-continue' handshake revisited
I have been trying to resolve the bug related to 'expect - continue'
handshake. We have been making some progress but I still have no clear
idea what may be causing this problem.
However, while working on this bug I have come to believe that 'expect:
100-continue' stuff in HttpClient is flaky and is in need of
improvement. The 'expect: 100-continue' related code is spread around a
few classes, is difficult to understand and to debug, and most
importantly error prone.
Here is my attempt at fixing the situation.
You feedback will be appreciated, as always, even if you end up tearing
it apart, again. ;-)
Cheers
Oleg
Re: [PATCH] 'expect: 100-continue' handshake revisited
Posted by Oleg Kalnichevski <o....@dplanet.ch>.
Folks
Any comments, objections, suggestions to this one?
Oleg
On Wed, 2003-02-26 at 22:25, Oleg Kalnichevski wrote:
> I have been trying to resolve the bug related to 'expect - continue'
> handshake. We have been making some progress but I still have no clear
> idea what may be causing this problem.
>
> However, while working on this bug I have come to believe that 'expect:
> 100-continue' stuff in HttpClient is flaky and is in need of
> improvement. The 'expect: 100-continue' related code is spread around a
> few classes, is difficult to understand and to debug, and most
> importantly error prone.
>
> Here is my attempt at fixing the situation.
>
> You feedback will be appreciated, as always, even if you end up tearing
> it apart, again. ;-)
>
> Cheers
>
> Oleg
>
> ______________________________________________________________________
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org
Re: [PATCH] 'expect: 100-continue' handshake revisited
Posted by Oleg Kalnichevski <o....@dplanet.ch>.
Ingo,
The patch was not supposed to solve the bug, as I still have no clear
idea what may be causing the problem in the first place. It is merely a
refactoring and code improvement patch, that should make
'expect-continue' stuff more robust.
It appears the problem is somehow related to the use of SSL, but I can't
tell more at the moment
Cheers
Oleg
On Thu, 2003-02-27 at 09:56, Ingo Brunberg wrote:
> Hi Oleg,
>
> I have tried your patch. Unfortunately it does not solve the
> problem. Sorry, that I cannot give you more help, but I also have no
> idea what might be causing that problem.
>
> Regards,
> Ingo
>
> > I have been trying to resolve the bug related to 'expect - continue'
> > handshake. We have been making some progress but I still have no clear
> > idea what may be causing this problem.
> >
> > However, while working on this bug I have come to believe that 'expect:
> > 100-continue' stuff in HttpClient is flaky and is in need of
> > improvement. The 'expect: 100-continue' related code is spread around a
> > few classes, is difficult to understand and to debug, and most
> > importantly error prone.
> >
> > Here is my attempt at fixing the situation.
> >
> > You feedback will be appreciated, as always, even if you end up tearing
> > it apart, again. ;-)
> >
> > Cheers
> >
> > Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org
>
Re: [PATCH] 'expect: 100-continue' handshake revisited
Posted by Ingo Brunberg <ib...@fiz-chemie.de>.
Hi Oleg,
I have tried your patch. Unfortunately it does not solve the
problem. Sorry, that I cannot give you more help, but I also have no
idea what might be causing that problem.
Regards,
Ingo
> I have been trying to resolve the bug related to 'expect - continue'
> handshake. We have been making some progress but I still have no clear
> idea what may be causing this problem.
>
> However, while working on this bug I have come to believe that 'expect:
> 100-continue' stuff in HttpClient is flaky and is in need of
> improvement. The 'expect: 100-continue' related code is spread around a
> few classes, is difficult to understand and to debug, and most
> importantly error prone.
>
> Here is my attempt at fixing the situation.
>
> You feedback will be appreciated, as always, even if you end up tearing
> it apart, again. ;-)
>
> Cheers
>
> Oleg