You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/30 01:56:05 UTC
[kudu-CR] benchmarks: split dense-node-itest graph by different types of data
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7341
to review the following change.
Change subject: benchmarks: split dense-node-itest graph by different types of data
......................................................................
benchmarks: split dense-node-itest graph by different types of data
The current graph tries to show times on the same axis as bytes, and
those are on entirely different scales. This splits the different
metrics into different graphs.
Change-Id: I0d121ecebf04f2c3347f6cb5c1c97bd426539f81
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/7341/1
--
To view, visit http://gerrit.cloudera.org:8080/7341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d121ecebf04f2c3347f6cb5c1c97bd426539f81
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] benchmarks: split dense-node-itest graph by different types of data
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: benchmarks: split dense-node-itest graph by different types of data
......................................................................
benchmarks: split dense-node-itest graph by different types of data
The current graph tries to show times on the same axis as bytes, and
those are on entirely different scales. This splits the different
metrics into different graphs.
Change-Id: I0d121ecebf04f2c3347f6cb5c1c97bd426539f81
Reviewed-on: http://gerrit.cloudera.org:8080/7341
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d121ecebf04f2c3347f6cb5c1c97bd426539f81
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] benchmarks: split dense-node-itest graph by different types of data
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: benchmarks: split dense-node-itest graph by different types of data
......................................................................
Patch Set 1: Verified+1
committing without jenkins since precommit doesn't run this script
--
To view, visit http://gerrit.cloudera.org:8080/7341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d121ecebf04f2c3347f6cb5c1c97bd426539f81
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] benchmarks: split dense-node-itest graph by different types of data
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: benchmarks: split dense-node-itest graph by different types of data
......................................................................
Patch Set 1: Code-Review+2
Thanks for doing this. Jenkins didn't trigger your build.
--
To view, visit http://gerrit.cloudera.org:8080/7341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d121ecebf04f2c3347f6cb5c1c97bd426539f81
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-HasComments: No