You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Andrew Yager (JIRA)" <ji...@apache.org> on 2006/06/20 12:31:37 UTC
[jira] Created: (OFBIZ-33) Display of State/Province for non US
entities
Display of State/Province for non US entities
---------------------------------------------
Key: OFBIZ-33
URL: http://issues.apache.org/jira/browse/OFBIZ-33
Project: The Open For Business Project
Type: Bug
Components: marketing
Versions: SVN trunk
Reporter: Andrew Yager
Priority: Minor
Attachments: companyheader.diff
State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-33) Display of State/Province for non US
entities
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-33?page=all ]
Si Chen closed OFBIZ-33:
------------------------
Resolution: Fixed
I committed a version very similar to this in SVN 7834. I did a null check on the .getRelatedOneCache(...) first because in my experience .getRelatedOneCache(...).get(...) inevitably would cause an NPE somewhere down the road.
This is a very good idea, by the way, but I think we'll need to generalize it, because there are so many addresses in so many places in OFBiz. I think probably what we'll need is an <@ofbizPostalAddress> transform similar to <@ofbizCurrency> which can get these abbreviations and format them correctly for the locale.
> Display of State/Province for non US entities
> ---------------------------------------------
>
> Key: OFBIZ-33
> URL: http://issues.apache.org/jira/browse/OFBIZ-33
> Project: The Open For Business Project
> Type: Bug
> Components: marketing
> Versions: SVN trunk
> Reporter: Andrew Yager
> Assignee: Si Chen
> Priority: Minor
> Attachments: companyheader-v2.diff, companyheader-v3.diff, companyheader.diff
>
> State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-33) Display of State/Province for non US
entities
Posted by "Andrew Yager (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-33?page=all ]
Andrew Yager updated OFBIZ-33:
------------------------------
Attachment: companyheader-v2.diff
better version that uses the abbreviation
> Display of State/Province for non US entities
> ---------------------------------------------
>
> Key: OFBIZ-33
> URL: http://issues.apache.org/jira/browse/OFBIZ-33
> Project: The Open For Business Project
> Type: Bug
> Components: marketing
> Versions: SVN trunk
> Reporter: Andrew Yager
> Priority: Minor
> Attachments: companyheader-v2.diff, companyheader.diff
>
> State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-33) Display of State/Province for non US
entities
Posted by "Andrew Yager (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-33?page=comments#action_12416999 ]
Andrew Yager commented on OFBIZ-33:
-----------------------------------
It seems to me as though this question would be better suited to my last patch (OFBIZ-34), rather than this one - as the intent of this was merely to correct the display so it no longer showed the geoID and instead displayed the state abbreviation.
As far as address formats - I learnt something today. This website (the first I found in google) lists some different address formats for different countries.
http://www.bitboost.com/ref/international-address-formats.html
Andrew
> Display of State/Province for non US entities
> ---------------------------------------------
>
> Key: OFBIZ-33
> URL: http://issues.apache.org/jira/browse/OFBIZ-33
> Project: The Open For Business Project
> Type: Bug
> Components: marketing
> Versions: SVN trunk
> Reporter: Andrew Yager
> Assignee: Si Chen
> Priority: Minor
> Attachments: companyheader-v2.diff, companyheader.diff
>
> State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-33) Display of State/Province for non US
entities
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-33?page=comments#action_12416931 ]
Si Chen commented on OFBIZ-33:
------------------------------
What URL does this happen in? Would you mind pasting a screenshot?
> Display of State/Province for non US entities
> ---------------------------------------------
>
> Key: OFBIZ-33
> URL: http://issues.apache.org/jira/browse/OFBIZ-33
> Project: The Open For Business Project
> Type: Bug
> Components: marketing
> Versions: SVN trunk
> Reporter: Andrew Yager
> Assignee: Si Chen
> Priority: Minor
> Attachments: companyheader-v2.diff, companyheader.diff
>
> State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-33) Display of State/Province for non US
entities
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-33?page=comments#action_12416940 ]
Si Chen commented on OFBIZ-33:
------------------------------
Never mind my last request. I looked at your patch and understand it now.
I think this is a good idea. However, I'd like you to modify it to use address.getRelatedOneCache("stateProvinceGeo") instead of the delegator.findByPrimarykey
Also, a more interesting question: it seems that in different countries these addresses are formatted differently. I think that's why the original PDFs were the way we were. Should we make it so that the display is country dependent?
Any thoughts, Hans??
> Display of State/Province for non US entities
> ---------------------------------------------
>
> Key: OFBIZ-33
> URL: http://issues.apache.org/jira/browse/OFBIZ-33
> Project: The Open For Business Project
> Type: Bug
> Components: marketing
> Versions: SVN trunk
> Reporter: Andrew Yager
> Assignee: Si Chen
> Priority: Minor
> Attachments: companyheader-v2.diff, companyheader.diff
>
> State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-33) Display of State/Province for non US
entities
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-33?page=all ]
Si Chen reassigned OFBIZ-33:
----------------------------
Assign To: Si Chen
> Display of State/Province for non US entities
> ---------------------------------------------
>
> Key: OFBIZ-33
> URL: http://issues.apache.org/jira/browse/OFBIZ-33
> Project: The Open For Business Project
> Type: Bug
> Components: marketing
> Versions: SVN trunk
> Reporter: Andrew Yager
> Assignee: Si Chen
> Priority: Minor
> Attachments: companyheader-v2.diff, companyheader.diff
>
> State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-33) Display of State/Province for non US
entities
Posted by "Andrew Yager (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-33?page=all ]
Andrew Yager updated OFBIZ-33:
------------------------------
Attachment: companyheader-v3.diff
Changed as per request by Si, also changed country to use address.getRelatedOneCache("CountryGeo") instead.
> Display of State/Province for non US entities
> ---------------------------------------------
>
> Key: OFBIZ-33
> URL: http://issues.apache.org/jira/browse/OFBIZ-33
> Project: The Open For Business Project
> Type: Bug
> Components: marketing
> Versions: SVN trunk
> Reporter: Andrew Yager
> Assignee: Si Chen
> Priority: Minor
> Attachments: companyheader-v2.diff, companyheader-v3.diff, companyheader.diff
>
> State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-33) Display of State/Province for non US
entities
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-33?page=comments#action_12417000 ]
Si Chen commented on OFBIZ-33:
------------------------------
That's true. Well, can you submit a slightly improved patch for this one so I can commit it for you?
Si
> Display of State/Province for non US entities
> ---------------------------------------------
>
> Key: OFBIZ-33
> URL: http://issues.apache.org/jira/browse/OFBIZ-33
> Project: The Open For Business Project
> Type: Bug
> Components: marketing
> Versions: SVN trunk
> Reporter: Andrew Yager
> Assignee: Si Chen
> Priority: Minor
> Attachments: companyheader-v2.diff, companyheader.diff
>
> State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-33) Display of State/Province for non US
entities
Posted by "Andrew Yager (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-33?page=comments#action_12442151 ]
Andrew Yager commented on OFBIZ-33:
-----------------------------------
[[ Old comment, sent by email on Wed, 21 Jun 2006 07:28:11 +1000 ]]
It seems to me as though this question would be better suited to my
last patch (OFBIZ-34), rather than this one - as the intent of this
was merely to correct the display so it no longer showed the geoID
and instead displayed the state abbreviation.
As far as address formats - I learnt something today. This website
(the first I found in google) lists some different address formats
for different countries.
http://www.bitboost.com/ref/international-address-formats.html
Andrew
> Display of State/Province for non US entities
> ---------------------------------------------
>
> Key: OFBIZ-33
> URL: http://issues.apache.org/jira/browse/OFBIZ-33
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: marketing
> Affects Versions: SVN trunk
> Reporter: Andrew Yager
> Assigned To: Si Chen
> Priority: Minor
> Attachments: companyheader-v2.diff, companyheader-v3.diff, companyheader.diff
>
>
> State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-33) Display of State/Province for non US
entities
Posted by "Andrew Yager (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-33?page=all ]
Andrew Yager updated OFBIZ-33:
------------------------------
Attachment: companyheader.diff
Fix attached for company header display
> Display of State/Province for non US entities
> ---------------------------------------------
>
> Key: OFBIZ-33
> URL: http://issues.apache.org/jira/browse/OFBIZ-33
> Project: The Open For Business Project
> Type: Bug
> Components: marketing
> Versions: SVN trunk
> Reporter: Andrew Yager
> Priority: Minor
> Attachments: companyheader.diff
>
> State/Province display in addresses shows the geo-id, which is fine for US entities where the GeoID is the state code, but for non-us entities, the GeoID is offen something like CountryCode-StateCode, which isn't very nice.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira