You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:56:31 UTC
[GitHub] [incubator-superset] codecov-io commented on pull request #11533: chore: consolidate datasource import logic
codecov-io commented on pull request #11533:
URL: https://github.com/apache/incubator-superset/pull/11533#issuecomment-720902035
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11533?src=pr&el=h1) Report
> Merging [#11533](https://codecov.io/gh/apache/incubator-superset/pull/11533?src=pr&el=desc) into [command_import_dash](https://codecov.io/gh/apache/incubator-superset/commit/305f05042c20c3b3b4c5075cfc139b88886bd91c?el=desc) will **decrease** coverage by `1.21%`.
> The diff coverage is `74.62%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11533?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## command_import_dash #11533 +/- ##
=======================================================
- Coverage 62.27% 61.06% -1.22%
=======================================================
Files 874 421 -453
Lines 41781 26173 -15608
Branches 3828 0 -3828
=======================================================
- Hits 26021 15983 -10038
+ Misses 15581 10190 -5391
+ Partials 179 0 -179
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `61.06% <74.62%> (-1.00%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11533?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.80% <0.00%> (+0.40%)` | :arrow_up: |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `80.95% <ø> (+16.13%)` | :arrow_up: |
| [superset/dashboards/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjAucHk=) | `81.04% <50.00%> (+0.12%)` | :arrow_up: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `78.86% <78.86%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.14% <100.00%> (-0.35%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.63% <100.00%> (+<0.01%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| ... and [477 more](https://codecov.io/gh/apache/incubator-superset/pull/11533/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11533?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11533?src=pr&el=footer). Last update [305f050...e318242](https://codecov.io/gh/apache/incubator-superset/pull/11533?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org