You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/13 11:56:35 UTC

[GitHub] [apisix] spacewander opened a new pull request #2743: feat: support ENV variable in configuration

spacewander opened a new pull request #2743:
URL: https://github.com/apache/apisix/pull/2743


   Close #2675.
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] nic-chen commented on pull request #2743: feat: support ENV variable in configuration

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2743:
URL: https://github.com/apache/apisix/pull/2743#issuecomment-726729684


   nice feature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] agile6v commented on a change in pull request #2743: feat: support ENV variable in configuration

Posted by GitBox <gi...@apache.org>.
agile6v commented on a change in pull request #2743:
URL: https://github.com/apache/apisix/pull/2743#discussion_r523405018



##########
File path: .travis/apisix_cli_test.sh
##########
@@ -144,6 +144,50 @@ fi
 
 echo "passed: change default env"
 
+# support environment varialbes

Review comment:
       `varialbes` => `variables`

##########
File path: .travis/apisix_cli_test.sh
##########
@@ -144,6 +144,50 @@ fi
 
 echo "passed: change default env"
 
+# support environment varialbes

Review comment:
       There are some typos below.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #2743: feat: support ENV variable in configuration

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2743:
URL: https://github.com/apache/apisix/pull/2743


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #2743: feat: support ENV variable in configuration

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2743:
URL: https://github.com/apache/apisix/pull/2743#discussion_r523408615



##########
File path: .travis/apisix_cli_test.sh
##########
@@ -144,6 +144,50 @@ fi
 
 echo "passed: change default env"
 
+# support environment varialbes

Review comment:
       @agile6v 
   Typo fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] agile6v commented on a change in pull request #2743: feat: support ENV variable in configuration

Posted by GitBox <gi...@apache.org>.
agile6v commented on a change in pull request #2743:
URL: https://github.com/apache/apisix/pull/2743#discussion_r523406024



##########
File path: .travis/apisix_cli_test.sh
##########
@@ -144,6 +144,50 @@ fi
 
 echo "passed: change default env"
 
+# support environment varialbes

Review comment:
       There are same typos below.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org