You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org> on 2007/07/25 11:35:31 UTC
[jira] Created: (HARMONY-4532) [classlib][luni] HashMap constructor
should re-calculate the capacity
[classlib][luni] HashMap constructor should re-calculate the capacity
---------------------------------------------------------------------
Key: HARMONY-4532
URL: https://issues.apache.org/jira/browse/HARMONY-4532
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Jimmy, Jing Lv
According to our hash map algorithm, we should re-calculate the capacity in the constructor when the capacity is passed in as a parameter. Currently HashMap(int,float) lacks this re-calculation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4532) [classlib][luni] HashMap constructor
should re-calculate the capacity
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leo Li updated HARMONY-4532:
----------------------------
Issue Type: Improvement (was: Bug)
> [classlib][luni] HashMap constructor should re-calculate the capacity
> ---------------------------------------------------------------------
>
> Key: HARMONY-4532
> URL: https://issues.apache.org/jira/browse/HARMONY-4532
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Assignee: Leo Li
> Attachments: Harmony4532.diff
>
>
> According to our hash map algorithm, we should re-calculate the capacity in the constructor when the capacity is passed in as a parameter. Currently HashMap(int,float) lacks this re-calculation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4532) [classlib][luni] HashMap constructor
should re-calculate the capacity
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy, Jing Lv updated HARMONY-4532:
------------------------------------
Attachment: Harmony4532.diff
Hi,
This bug will only cause performance issues( &(bucketsize-1) will then make a bad index), but no logic error will occur in get/put method. So no testcase can be written here.
Would you please try my patch? Thanks!
Jimmy
> [classlib][luni] HashMap constructor should re-calculate the capacity
> ---------------------------------------------------------------------
>
> Key: HARMONY-4532
> URL: https://issues.apache.org/jira/browse/HARMONY-4532
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Assignee: Leo Li
> Attachments: Harmony4532.diff
>
>
> According to our hash map algorithm, we should re-calculate the capacity in the constructor when the capacity is passed in as a parameter. Currently HashMap(int,float) lacks this re-calculation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4532) [classlib][luni] HashMap
constructor should re-calculate the capacity
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leo Li resolved HARMONY-4532.
-----------------------------
Resolution: Fixed
Hi, Jimmy
Patch applied at r559406. Thank you for your improvement. Please verify whether the problem is resolved as you expected.
Good luck!
Leo.
> [classlib][luni] HashMap constructor should re-calculate the capacity
> ---------------------------------------------------------------------
>
> Key: HARMONY-4532
> URL: https://issues.apache.org/jira/browse/HARMONY-4532
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Assignee: Leo Li
> Attachments: Harmony4532.diff
>
>
> According to our hash map algorithm, we should re-calculate the capacity in the constructor when the capacity is passed in as a parameter. Currently HashMap(int,float) lacks this re-calculation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4532) [classlib][luni] HashMap constructor
should re-calculate the capacity
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison closed HARMONY-4532.
--------------------------------
No response, assuming ok.
> [classlib][luni] HashMap constructor should re-calculate the capacity
> ---------------------------------------------------------------------
>
> Key: HARMONY-4532
> URL: https://issues.apache.org/jira/browse/HARMONY-4532
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Assignee: Leo Li
> Attachments: Harmony4532.diff
>
>
> According to our hash map algorithm, we should re-calculate the capacity in the constructor when the capacity is passed in as a parameter. Currently HashMap(int,float) lacks this re-calculation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4532) [classlib][luni] HashMap
constructor should re-calculate the capacity
Posted by "Leo Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leo Li reassigned HARMONY-4532:
-------------------------------
Assignee: Leo Li
> [classlib][luni] HashMap constructor should re-calculate the capacity
> ---------------------------------------------------------------------
>
> Key: HARMONY-4532
> URL: https://issues.apache.org/jira/browse/HARMONY-4532
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Assignee: Leo Li
>
> According to our hash map algorithm, we should re-calculate the capacity in the constructor when the capacity is passed in as a parameter. Currently HashMap(int,float) lacks this re-calculation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.