You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/09/15 16:58:36 UTC
Re: Review Request 34104: Fix for SQOOP-1369 Avro export ignores
--columns option
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34104/#review99034
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Aug. 11, 2015, 7:36 p.m., Paul Mazak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34104/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 7:36 p.m.)
>
>
> Review request for Sqoop and Yibing Shi.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Supplied a patch that worked for us.
> There are 2 global places to consider - parent class SqlManager and child class CatalogQueryManager - when returning getColumnNames to actually rely on those column names you specified with --columns option.
> There was 1 place to consider for Avro/Parquet in JdbcExportJob.configureGenericRecordExportInputFormat() to only add the columnType if it's one that was specified with --columns option.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/SqoopOptions.java ace90fd
> src/java/org/apache/sqoop/manager/CatalogQueryManager.java 4e063ed
> src/java/org/apache/sqoop/manager/OracleManager.java 69b613f
> src/java/org/apache/sqoop/manager/SqlManager.java ead581d
> src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java 93d438a
> src/test/com/cloudera/sqoop/TestAvroExport.java 663828c
> src/test/org/apache/sqoop/TestSqoopOptions.java 87b340a
> src/test/org/apache/sqoop/manager/TestSqlManager.java PRE-CREATION
> src/test/org/apache/sqoop/mapreduce/TestJdbcExportJob.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34104/diff/
>
>
> Testing
> -------
>
> Integration testing passed exporting AVRO to MS SQL Server
>
>
> Thanks,
>
> Paul Mazak
>
>