You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2016/03/09 05:14:40 UTC
[jira] [Commented] (YARN-4779) Fix AM container allocation logic in
SLS
[ https://issues.apache.org/jira/browse/YARN-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186468#comment-15186468 ]
Hadoop QA commented on YARN-4779:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s {color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 54s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 14s {color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 20s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 31s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s {color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 11s {color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 36s {color} | {color:red} hadoop-tools_hadoop-sls-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 13s {color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 49s {color} | {color:red} hadoop-tools_hadoop-sls-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s {color} | {color:red} hadoop-tools/hadoop-sls: patch generated 14 new + 75 unchanged - 9 fixed = 89 total (was 84) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 46s {color} | {color:red} hadoop-tools/hadoop-sls generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 11s {color} | {color:green} hadoop-tools_hadoop-sls-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 20 unchanged - 3 fixed = 20 total (was 23) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s {color} | {color:green} hadoop-sls in the patch passed with JDK v1.8.0_74. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s {color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 49s {color} | {color:red} hadoop-sls in the patch failed with JDK v1.8.0_74. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 51s {color} | {color:red} hadoop-sls in the patch failed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s {color} | {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 48s {color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-tools/hadoop-sls |
| | Inconsistent synchronization of org.apache.hadoop.yarn.sls.appmaster.AMSimulator.amContainer; locked 50% of time Unsynchronized access at MRAMSimulator.java:50% of time Unsynchronized access at MRAMSimulator.java:[line 194] |
| JDK v1.8.0_74 Failed junit tests | hadoop.yarn.sls.appmaster.TestAMSimulator |
| | hadoop.yarn.sls.scheduler.TestTaskRunner |
| JDK v1.7.0_95 Failed junit tests | hadoop.yarn.sls.appmaster.TestAMSimulator |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12792125/YARN-4779.1.patch |
| JIRA Issue | YARN-4779 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux d3cbdc9c14dd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 55f73a1 |
| Default Java | 1.7.0_95 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 |
| findbugs | v3.0.0 |
| javac | hadoop-tools_hadoop-sls-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-YARN-Build/10729/artifact/patchprocess/diff-compile-javac-hadoop-tools_hadoop-sls-jdk1.8.0_74.txt |
| javac | hadoop-tools_hadoop-sls-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-YARN-Build/10729/artifact/patchprocess/diff-compile-javac-hadoop-tools_hadoop-sls-jdk1.7.0_95.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/10729/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-sls.txt |
| findbugs | https://builds.apache.org/job/PreCommit-YARN-Build/10729/artifact/patchprocess/new-findbugs-hadoop-tools_hadoop-sls.html |
| unit | https://builds.apache.org/job/PreCommit-YARN-Build/10729/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls-jdk1.8.0_74.txt |
| unit | https://builds.apache.org/job/PreCommit-YARN-Build/10729/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls-jdk1.7.0_95.txt |
| unit test logs | https://builds.apache.org/job/PreCommit-YARN-Build/10729/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10729/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls-jdk1.7.0_95.txt |
| JDK v1.7.0_95 Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/10729/testReport/ |
| modules | C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/10729/console |
| Powered by | Apache Yetus 0.2.0 http://yetus.apache.org |
This message was automatically generated.
> Fix AM container allocation logic in SLS
> ----------------------------------------
>
> Key: YARN-4779
> URL: https://issues.apache.org/jira/browse/YARN-4779
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-4779.1.patch
>
>
> Currently, SLS uses unmanaged AM for simulated map-reduce applications. And first allocated container for each app is considered to be the master container.
> This could be problematic when preemption happens. CapacityScheduler preempt AM container at lowest priority, but the simulated AM container isn't recognized by scheduler -- it is a normal container from scheduler's perspective.
> This JIRA tries to fix this logic: do the real AM allocation instead of using unmanaged AM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)