You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/21 01:20:17 UTC
[GitHub] [incubator-seatunnel] simon824 commented on a change in pull request #1117: [SeaTunnel #1116] Optimize CheckConfigUtil and add UT
simon824 commented on a change in pull request #1117:
URL: https://github.com/apache/incubator-seatunnel/pull/1117#discussion_r789270021
##########
File path: seatunnel-common/src/main/java/org/apache/seatunnel/common/config/CheckConfigUtil.java
##########
@@ -26,17 +26,14 @@
public class CheckConfigUtil {
- public static CheckResult check(Config config, String... params) {
- StringBuilder missingParams = new StringBuilder();
- for (String param : params) {
- if (!config.hasPath(param) || config.getAnyRef(param) == null) {
- missingParams.append(param).append(",");
- }
- }
+ public static CheckResult checkAllExists(Config config, String... params) {
Review comment:
make sense, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org