You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/08 17:42:59 UTC
[GitHub] [spark] ueshin commented on a change in pull request #33931: [SPARK-36689][PYTHON] Cleanup the deprecated APIs and raise proper warning message.
ueshin commented on a change in pull request #33931:
URL: https://github.com/apache/spark/pull/33931#discussion_r704636791
##########
File path: python/pyspark/pandas/missing/series.py
##########
@@ -47,22 +43,19 @@ class MissingPandasLikeSeries(object):
resample = _unsupported_function("resample")
searchsorted = _unsupported_function("searchsorted")
set_axis = _unsupported_function("set_axis")
- slice_shift = _unsupported_function("slice_shift")
to_hdf = _unsupported_function("to_hdf")
to_period = _unsupported_function("to_period")
to_sql = _unsupported_function("to_sql")
to_timestamp = _unsupported_function("to_timestamp")
- tshift = _unsupported_function("tshift")
tz_convert = _unsupported_function("tz_convert")
tz_localize = _unsupported_function("tz_localize")
view = _unsupported_function("view")
# Deprecated functions
- convert_objects = _unsupported_function("convert_objects", deprecated=True)
- nonzero = _unsupported_function("nonzero", deprecated=True)
- reindex_axis = _unsupported_function("reindex_axis", deprecated=True)
- select = _unsupported_function("select", deprecated=True)
- get_values = _unsupported_function("get_values", deprecated=True)
+ slice_shift = _unsupported_function(
+ "slice_shift", deprecated=True, reason="Use DataFrame/Series.shift instead."
+ )
+ tshift = _unsupported_function("slice_shift", deprecated=True, reason="Use `shift` instead.")
Review comment:
`"tshift"` instead of `"slice_shift"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org