[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2626: Optimize the ping method

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #2626:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2626#discussion_r737108359



##########
File path: foundations/foundation-registry/src/main/java/org/apache/servicecomb/registry/consumer/SimpleMicroserviceInstancePing.java
##########
@@ -23,27 +23,34 @@
 import org.apache.servicecomb.foundation.common.net.IpPort;
 import org.apache.servicecomb.foundation.common.net.NetUtils;
 import org.apache.servicecomb.registry.api.registry.MicroserviceInstance;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.util.CollectionUtils;
 
 /**
  * Simple implementation of .MicroserviceInstancePing using telnet
  */
 public class SimpleMicroserviceInstancePing implements MicroserviceInstancePing {
+  private static final Logger LOGGER = LoggerFactory.getLogger(SimpleMicroserviceInstancePing.class);

Review comment:
       1. use etc/*.xml code formatter formate code
   2. create a JIRA issue and submit a PR with JIRA id, see other PRs




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org