You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/11 15:07:54 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4800: kvm: Do not rebase DATADISK in vm start/migration
ustcweizhou opened a new pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800
### Description
We do not need to rebase the qcow2 image of DATADISK and ROOT disk which does not have a backing file.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-801036404
Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rubieHess commented on a change in pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
rubieHess commented on a change in pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#discussion_r598318705
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4266,7 +4266,11 @@ public void setBackingFileFormat(String volPath) {
Map<String, String> info = qemu.info(file);
String backingFilePath = info.get(new String("backing_file"));
Review comment:
I detect that this code is problematic. According to the [Performance (PERFORMANCE)](https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#performance-performance), [Dm: Method invokes inefficient new String(String) constructor (DM_STRING_CTOR)](https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#dm-method-invokes-inefficient-new-string-string-constructor-dm-string-ctor).
Using the java.lang.String(String) constructor wastes memory because the object so constructed will be functionally indistinguishable from the String passed as a parameter. Just use the argument String directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797406054
> > @weizhouapache I'm confused by your description in context of the code change. If we do have a disk, but no backing format, we go ahead and rebase it as qcow2, am I right?
> > and if we don't have a file path or we do have a backing format, we do nothing.
>
> @DaanHoogland I changed the title and description.
>
> we do nothing if (1) disk does not have a backing file ; (2) disk has backing file, and also backing file format.
> we set backing file format only if disk has a backing file but backing file format is missing
exactly what the code does, good text for the tin ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-801011232
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rubieHess commented on a change in pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
rubieHess commented on a change in pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#discussion_r598679215
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4266,7 +4266,11 @@ public void setBackingFileFormat(String volPath) {
Map<String, String> info = qemu.info(file);
String backingFilePath = info.get(new String("backing_file"));
Review comment:
Happy to help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-799236581
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not rebase DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-796827718
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-801705742
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-801706232
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#discussion_r598518007
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4266,7 +4266,11 @@ public void setBackingFileFormat(String volPath) {
Map<String, String> info = qemu.info(file);
String backingFilePath = info.get(new String("backing_file"));
Review comment:
@rubieHess good point. thanks ! I will create a pr for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#discussion_r593155348
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4266,7 +4266,8 @@ public void setBackingFileFormat(String volPath) {
Map<String, String> info = qemu.info(file);
String backingFilePath = info.get(new String("backing_file"));
String backingFileFormat = info.get(new String("backing_file_format"));
- if (org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
+ if (org.apache.commons.lang.StringUtils.isNotBlank(backingFilePath)
+ && org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
Review comment:
@rhtyd then it is fine, we do nothing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not rebase DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797054860
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-799236879
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-801010555
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not rebase DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797292083
<b>[S] Trillian test result (tid-91)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34323 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4800-t91-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 80.66 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 48.22 | test_vm_life_cycle.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#discussion_r593146838
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4266,7 +4266,8 @@ public void setBackingFileFormat(String volPath) {
Map<String, String> info = qemu.info(file);
String backingFilePath = info.get(new String("backing_file"));
String backingFileFormat = info.get(new String("backing_file_format"));
- if (org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
+ if (org.apache.commons.lang.StringUtils.isNotBlank(backingFilePath)
+ && org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
Review comment:
What if the backing file format is not empty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4800: kvm: Do not rebase DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-796827098
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-799234990
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797392700
> @weizhouapache I'm confused by your description in context of the code change. If we do have a disk, but no backing format, we go ahead and rebase it as qcow2, am I right?
> and if we don't have a file path or we do have a backing format, we do nothing.
@DaanHoogland I changed the title and description.
we do nothing if (1) disk does not have a backing file ; (2) disk has backing file, and also backing file format.
we set backing file format only if disk has a backing file but backing file format is missing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797392700
> @weizhouapache I'm confused by your description in context of the code change. If we do have a disk, but no backing format, we go ahead and rebase it as qcow2, am I right?
> and if we don't have a file path or we do have a backing format, we do nothing.
@DaanHoogland I changed the title and description.
we do nothing if (1) disk does not have a backing file ; (2) disk has backing file, and also backing file format.
we set backing file format only if disk has a backing file but does not have backing file format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4800: kvm: Do not rebase DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797054398
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-805552594
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-806029123
<b>Trillian test result (tid-245)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36842 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4800-t245-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 82.99 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 52.30 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#discussion_r593171611
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4266,7 +4266,8 @@ public void setBackingFileFormat(String volPath) {
Map<String, String> info = qemu.info(file);
String backingFilePath = info.get(new String("backing_file"));
String backingFileFormat = info.get(new String("backing_file_format"));
- if (org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
+ if (org.apache.commons.lang.StringUtils.isNotBlank(backingFilePath)
+ && org.apache.commons.lang.StringUtils.isEmpty(backingFileFormat)) {
Review comment:
> Maybe some log messages for debug/warn purposes would be interesting. Or do you think that it is something that system admins should not be bothered with?
>
> I am thinking especially on cases such as `backingFileFormat` not empty and blank/empty `backingFilePath`, or _vice versa_.
>
> Additionally, what do you think of replacing `StringUtils.isEmpty(backingFileFormat)` with `StringUtils.isBlank(backingFileFormat)`? In such case it would then check if `backingFileFormat` is whitespace, empty ("") or null.
@GabrielBrascher there is a info next to these lines
```
s_logger.info("Setting backing file format of " + volPath);
```
I will add a line as comment to explain why we need this change.
https://libvirt.org/kbase/backing_chains.html#vm-refuses-to-start-due-to-misconfigured-backing-store-format
StringUtils.isBlank(backingFileFormat) and StringUtils.isEmpty(backingFileFormat) have no difference I think. there are only 2 possible values: empty and 'qcow2'. I will change to isBlank
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4800: kvm: Do not rebase DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-797389521
@weizhouapache I'm confused by your description in context of the code change. If we do have a disk, but no backing format, we go ahead and rebase it as qcow2, am I right?
and if we don't have a file path or we do have a backing format, we do nothing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not set backing file format of DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-805553156
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4800: kvm: Do not rebase DATADISK in vm start/migration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4800:
URL: https://github.com/apache/cloudstack/pull/4800#issuecomment-796844514
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org