You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/10/19 00:17:18 UTC

[GitHub] [beam] tvalentyn commented on a diff in pull request #23696: Update portable runner test timeout

tvalentyn commented on code in PR #23696:
URL: https://github.com/apache/beam/pull/23696#discussion_r998815354


##########
sdks/python/apache_beam/runners/portability/portable_runner_test.py:
##########
@@ -91,7 +91,8 @@ def _start_local_runner_subprocess_job_service(cls):
         GRPCChannelFactory.insecure_channel(address))
     _LOGGER.info('Waiting for server to be ready...')
     start = time.time()
-    timeout = 30
+    # Long timeout based previously flaky test. See issue #22115.
+    timeout = 300

Review Comment:
   can you rename it to timeout_sec please?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org