You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2018/03/30 21:42:20 UTC
[Impala-ASF-CR](2.x) Revert "IMPALA-6747: Automate diagnostics collection."
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9875
Change subject: Revert "IMPALA-6747: Automate diagnostics collection."
......................................................................
Revert "IMPALA-6747: Automate diagnostics collection."
A couple of things donot work in python2.6
-- Multiple with statements in the same context
-- shutil.make_archive()
I need a little more time to test the fix with python2.6.
Meanwhile, reverting this to unblock others. I'll resubmit
the fix when I'm confident that it works with python2.6
This reverts commit 2883c9950026db74240a69ab07e867810b8547b0.
Change-Id: I221ede9d5eb4d89ea20992cc27a8284803af3223
Reviewed-on: http://gerrit.cloudera.org:8080/9872
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Michael Ho <kw...@cloudera.com>
(cherry picked from commit cf4f314922f13fbf54c6d7300ceaa2229bf5916a)
---
D bin/diagnostics/__init__.py
D bin/diagnostics/collect_diagnostics.py
D bin/diagnostics/collect_shared_libs.sh
M bin/rat_exclude_files.txt
D tests/unittests/test_command.py
5 files changed, 0 insertions(+), 620 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/9875/1
--
To view, visit http://gerrit.cloudera.org:8080/9875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I221ede9d5eb4d89ea20992cc27a8284803af3223
Gerrit-Change-Number: 9875
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR](2.x) Revert "IMPALA-6747: Automate diagnostics collection."
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9875 )
Change subject: Revert "IMPALA-6747: Automate diagnostics collection."
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9875/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9875/1//COMMIT_MSG@23
PS1, Line 23: (cherry picked from commit cf4f314922f13fbf54c6d7300ceaa2229bf5916a)
> I clicked the cherry pick button on gerrit. Is this an issue?
Don't think so. If you did that, change-id is almost certainly the same which is helpful.
--
To view, visit http://gerrit.cloudera.org:8080/9875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I221ede9d5eb4d89ea20992cc27a8284803af3223
Gerrit-Change-Number: 9875
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Mar 2018 22:16:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) Revert "IMPALA-6747: Automate diagnostics collection."
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9875 )
Change subject: Revert "IMPALA-6747: Automate diagnostics collection."
......................................................................
Patch Set 1:
We might want to cherry-pick this fix to 2.x without going through the cherry-picking job to unblock the builds.
--
To view, visit http://gerrit.cloudera.org:8080/9875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I221ede9d5eb4d89ea20992cc27a8284803af3223
Gerrit-Change-Number: 9875
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Mar 2018 21:45:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) Revert "IMPALA-6747: Automate diagnostics collection."
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9875 )
Change subject: Revert "IMPALA-6747: Automate diagnostics collection."
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
As far as I'm concerned, we can push through the revert without waiting for GVO.
http://gerrit.cloudera.org:8080/#/c/9875/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9875/1//COMMIT_MSG@23
PS1, Line 23: (cherry picked from commit cf4f314922f13fbf54c6d7300ceaa2229bf5916a)
Did you use cherry-pick -x here? Usually the regular cherry pick job uses without -x, which doesn't produce this line.
--
To view, visit http://gerrit.cloudera.org:8080/9875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I221ede9d5eb4d89ea20992cc27a8284803af3223
Gerrit-Change-Number: 9875
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Mar 2018 21:56:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) Revert "IMPALA-6747: Automate diagnostics collection."
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9875 )
Change subject: Revert "IMPALA-6747: Automate diagnostics collection."
......................................................................
Revert "IMPALA-6747: Automate diagnostics collection."
A couple of things donot work in python2.6
-- Multiple with statements in the same context
-- shutil.make_archive()
I need a little more time to test the fix with python2.6.
Meanwhile, reverting this to unblock others. I'll resubmit
the fix when I'm confident that it works with python2.6
This reverts commit 2883c9950026db74240a69ab07e867810b8547b0.
Change-Id: I221ede9d5eb4d89ea20992cc27a8284803af3223
Reviewed-on: http://gerrit.cloudera.org:8080/9872
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Michael Ho <kw...@cloudera.com>
(cherry picked from commit cf4f314922f13fbf54c6d7300ceaa2229bf5916a)
Reviewed-on: http://gerrit.cloudera.org:8080/9875
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Tianyi Wang <tw...@cloudera.com>
---
D bin/diagnostics/__init__.py
D bin/diagnostics/collect_diagnostics.py
D bin/diagnostics/collect_shared_libs.sh
M bin/rat_exclude_files.txt
D tests/unittests/test_command.py
5 files changed, 0 insertions(+), 620 deletions(-)
Approvals:
Philip Zeyliger: Looks good to me, approved
Tianyi Wang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I221ede9d5eb4d89ea20992cc27a8284803af3223
Gerrit-Change-Number: 9875
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR](2.x) Revert "IMPALA-6747: Automate diagnostics collection."
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9875 )
Change subject: Revert "IMPALA-6747: Automate diagnostics collection."
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9875/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9875/1//COMMIT_MSG@23
PS1, Line 23: (cherry picked from commit cf4f314922f13fbf54c6d7300ceaa2229bf5916a)
> Did you use cherry-pick -x here? Usually the regular cherry pick job uses w
I clicked the cherry pick button on gerrit. Is this an issue?
--
To view, visit http://gerrit.cloudera.org:8080/9875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I221ede9d5eb4d89ea20992cc27a8284803af3223
Gerrit-Change-Number: 9875
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Mar 2018 22:02:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) Revert "IMPALA-6747: Automate diagnostics collection."
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9875 )
Change subject: Revert "IMPALA-6747: Automate diagnostics collection."
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I221ede9d5eb4d89ea20992cc27a8284803af3223
Gerrit-Change-Number: 9875
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Mar 2018 22:21:18 +0000
Gerrit-HasComments: No