You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/07 14:47:51 UTC
[GitHub] [pulsar] MMirelli opened a new pull request #11951: Fixing permissions of docker images scripts
MMirelli opened a new pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951
### Motivation
Deploying pulsar on kubernetes from a docker image leads to a failure deploying the cluster. This is due to insufficient permissions assigned to python scripts in `/docker/pulsar/scripts`, as further explained in my emails to the [dev mailing list](https://lists.apache.org/list.html?dev@pulsar.apache.org) - [VOTE] Pulsar Release 2.8.1 Candidate 3.
### Modifications
Adding exec permissions to the python scripts in `/docker/pulsar/scripts`.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Anything that affects deployment: yes
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] doc-required
- [x] no-need-doc
It is just a small fix only impacting deployment on kubernetes.
- [ ] doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MMirelli edited a comment on pull request #11951: Fixing permissions of docker images scripts
Posted by GitBox <gi...@apache.org>.
MMirelli edited a comment on pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951#issuecomment-915005547
For completeness I will also add the `pulsar-values.yaml`:
```
enableAntiAffinity: false
initialize: true # ASF Helm Chart
affinity: # ASF Helm Chart
anti_affinity: no
restartOnConfigMapChange:
enabled: yes
enableTls: yes
cert-manager:
enabled: true
createCertificates:
selfSigned:
enabled: true
enableTokenAuth: yes
autoRecovery:
enableProvisionContainer: yes
image:
zookeeper:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
bookie:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
bookkeeper:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
autorecovery:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
broker:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
proxy:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
functions:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
function:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
extra:
function: yes
burnell: yes
burnellLogCollector: yes
pulsarHeartbeat: yes
pulsarAdminConsole: yes
autoRecovery: yes
functionsAsPods: yes
default_storage:
existingStorageClassName: server-storage
volumes:
data: #ASF Helm Chart
storageClassName: existent-storage-class
zookeeper:
replicaCount: 1
bookkeeper:
replicaCount: 3
broker:
component: broker
replicaCount: 1
ledger:
defaultEnsembleSize: 2
defaultAckQuorum: 2
defaultWriteQuorum: 2
configData:
loadBalancerBrokerOverloadedThresholdPercentage: "95"
loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.impl.OverloadShedder"
loadBalancerBrokerThresholdShedderPercentage: "10"
function:
replicaCount: 1
functionReplicaCount: 1
runtime: "kubernetes"
proxy:
replicaCount: 1
autoPortAssign:
enablePlainTextWithTLS: yes
service:
type: ClusterIP
autoPortAssign:
enabled: yes
grafanaDashboards:
enabled: no
pulsarAdminConsole:
replicaCount: 0
service:
type: ClusterIP
grafana: #ASF Helm Chart
service:
type: ClusterIP
pulsar_manager:
service:
type: ClusterIP
kube-prometheus-stack:
enabled: no
prometheusOperator:
enabled: no
grafana:
enabled: no
adminPassword: e9JYtk83*4#PM8
service:
type: ClusterIP
pulsarSQL:
service:
type: ClusterIP
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #11951: Fixing permissions of docker images scripts
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951#issuecomment-914646154
@MMirelli - can you help me understand why this change is necessary? In the 2.8.0 image, permissions look correct, and I am not finding any changes that should have introduced the regression you're seeing. Thanks.
```shell
mmarshall-rmbp16:pulsar michaelmarshall$ docker run -it --entrypoint bash apachepulsar/pulsar:2.8.0
root@aac8f48fb859:/pulsar# ls -al bin/
total 112
drwxr-xr-x 3 root root 4096 Jun 15 07:48 .
drwxr-xr-x 1 root root 4096 Jun 15 07:48 ..
-rwxr-xr-x 1 root root 3060 Jun 12 04:27 apply-config-from-env-with-prefix.py
-rwxr-xr-x 1 root root 3117 Jun 12 04:27 apply-config-from-env.py
-rwxr-xr-x 1 root root 6966 Jan 22 2020 bookkeeper
-rwxr-xr-x 1 root root 5361 Jan 22 2020 function-localrunner
-rwxr-xr-x 1 root root 3267 Jun 12 04:27 gen-yml-from-env.py
-rwxr-xr-x 1 root root 1686 Jun 12 04:27 generate-zookeeper-config.sh
-rwxr-xr-x 1 root root 925 Jun 12 04:27 install-pulsar-client-37.sh
drwxr-xr-x 2 root root 4096 Jan 22 2020 proto
-rwxr-xr-x 1 root root 16177 Jan 22 2020 pulsar
-rwxr-xr-x 1 root root 1073 Jan 22 2020 pulsar-admin
-rwxr-xr-x 1 root root 3495 Jan 22 2020 pulsar-admin-common.sh
-rwxr-xr-x 1 root root 3542 Jan 22 2020 pulsar-client
-rwxr-xr-x 1 root root 5838 Jan 22 2020 pulsar-daemon
-rwxr-xr-x 1 root root 11590 Jan 22 2020 pulsar-managed-ledger-admin
-rwxr-xr-x 1 root root 6091 Jan 22 2020 pulsar-perf
-rwxr-xr-x 1 root root 970 Jun 12 04:27 pulsar-zookeeper-ruok.sh
-rwxr-xr-x 1 root root 2911 Jun 12 04:27 watch-znode.py
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #11951: Fixing permissions of docker images scripts packaged in source tar ball
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951#issuecomment-985236549
Closing and reopening to trigger CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #11951: Fixing permissions of docker images scripts packaged in source tar ball
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951#issuecomment-956005013
/pulsar-bot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MMirelli edited a comment on pull request #11951: Fixing permissions of docker images scripts
Posted by GitBox <gi...@apache.org>.
MMirelli edited a comment on pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951#issuecomment-915003000
@michaeljmarshall - thanks for pointing that out, I have also updated the description^. So the fact is that I built the docker images from the tar ball and pushed them to my own docker hub.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #11951: Fix permissions of docker images scripts packaged in source tar ball
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MMirelli commented on pull request #11951: Fixing permissions of docker images scripts
Posted by GitBox <gi...@apache.org>.
MMirelli commented on pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951#issuecomment-915005547
For completeness I will also add the `pulsar-values.yaml`:
```
enableAntiAffinity: false
initialize: true # ASF Helm Chart
affinity: # ASF Helm Chart
anti_affinity: no
restartOnConfigMapChange:
enabled: yes
enableTls: yes
cert-manager:
enabled: true
createCertificates:
selfSigned:
enabled: true
enableTokenAuth: yes
autoRecovery:
enableProvisionContainer: yes
image:
zookeeper:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
bookie:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
bookkeeper:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
autorecovery:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
broker:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
proxy:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
functions:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
function:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
extra:
function: yes
burnell: yes
burnellLogCollector: yes
pulsarHeartbeat: yes
pulsarAdminConsole: yes
autoRecovery: yes
functionsAsPods: yes
default_storage:
existingStorageClassName: server-storage
volumes:
data: #ASF Helm Chart
storageClassName: existent-storage-class
zookeeper:
replicaCount: 1
bookkeeper:
replicaCount: 3
broker:
component: broker
replicaCount: 1
ledger:
defaultEnsembleSize: 2
defaultAckQuorum: 2
defaultWriteQuorum: 2
configData:
loadBalancerBrokerOverloadedThresholdPercentage: "95"
loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.impl.OverloadShedder"
loadBalancerBrokerThresholdShedderPercentage: "10"
function:
replicaCount: 1
functionReplicaCount: 1
runtime: "kubernetes"
proxy:
replicaCount: 1
autoPortAssign:
enablePlainTextWithTLS: yes
service:
type: ClusterIP
autoPortAssign:
enabled: yes
grafanaDashboards:
enabled: no
pulsarAdminConsole:
replicaCount: 0
service:
type: ClusterIP
grafana: #ASF Helm Chart
service:
type: ClusterIP
pulsar_manager:
service: #ASF Helm Chart
type: ClusterIP
kube-prometheus-stack: # Luna Streaming Helm Chart
enabled: no
prometheusOperator:
enabled: no
grafana:
enabled: no
adminPassword: e9JYtk83*4#PM8
service:
type: ClusterIP
pulsarSQL:
service:
type: ClusterIP
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall closed pull request #11951: Fixing permissions of docker images scripts packaged in source tar ball
Posted by GitBox <gi...@apache.org>.
michaeljmarshall closed pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MMirelli edited a comment on pull request #11951: Fixing permissions of docker images scripts
Posted by GitBox <gi...@apache.org>.
MMirelli edited a comment on pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951#issuecomment-915005547
For completeness I will also add the `pulsar-values.yaml`:
```
enableAntiAffinity: false
initialize: true # ASF Helm Chart
affinity: # ASF Helm Chart
anti_affinity: no
restartOnConfigMapChange:
enabled: yes
enableTls: yes
cert-manager:
enabled: true
createCertificates:
selfSigned:
enabled: true
enableTokenAuth: yes
autoRecovery:
enableProvisionContainer: yes
image:
zookeeper:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
bookie:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
bookkeeper:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
autorecovery:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
broker:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
proxy:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
functions:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
function:
repository: massimilianomirelli/pulsar
tag: 2.8.1-rc3
extra:
function: yes
burnell: yes
burnellLogCollector: yes
pulsarHeartbeat: yes
pulsarAdminConsole: yes
autoRecovery: yes
functionsAsPods: yes
default_storage:
existingStorageClassName: server-storage
volumes:
data: #ASF Helm Chart
storageClassName: existent-storage-class
zookeeper:
replicaCount: 1
bookkeeper:
replicaCount: 3
broker:
component: broker
replicaCount: 1
ledger:
defaultEnsembleSize: 2
defaultAckQuorum: 2
defaultWriteQuorum: 2
configData:
loadBalancerBrokerOverloadedThresholdPercentage: "95"
loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.impl.OverloadShedder"
loadBalancerBrokerThresholdShedderPercentage: "10"
function:
replicaCount: 1
functionReplicaCount: 1
runtime: "kubernetes"
proxy:
replicaCount: 1
autoPortAssign:
enablePlainTextWithTLS: yes
service:
type: ClusterIP
autoPortAssign:
enabled: yes
grafanaDashboards:
enabled: no
pulsarAdminConsole:
replicaCount: 0
service:
type: ClusterIP
grafana: #ASF Helm Chart
service:
type: ClusterIP
pulsar_manager:
service:
type: ClusterIP
pulsarSQL:
service:
type: ClusterIP
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MMirelli commented on pull request #11951: Fixing permissions of docker images scripts
Posted by GitBox <gi...@apache.org>.
MMirelli commented on pull request #11951:
URL: https://github.com/apache/pulsar/pull/11951#issuecomment-915003000
@michaeljmarshall - sure, so the fact is that I built the docker images from the tar ball. I did not pulled them from the official docker hub repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org