You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2010/09/03 20:38:39 UTC

Re: svn commit: r992390 - in /subversion/trunk/subversion: include/private/svn_sqlite.h libsvn_subr/sqlite.c libsvn_wc/wc_db.c libsvn_wc/wc_db.h

rhuijben@apache.org wrote on Fri, Sep 03, 2010 at 17:34:52 -0000:
> +      for (i = 0; i < db->nbr_statements; i++)
> +        if (db->prepared_stmts[i] && db->prepared_stmts[i]->needs_reset)
> +          err2 = svn_error_compose_create(
> +                     err2,
> +                     svn_sqlite__reset(db->prepared_stmts[i]));
> +
> +          err2 = svn_error_compose_create(
> +                      exec_sql(db, release_stmt),
> +                      err2);

Should the second "err2 = ..." line be inside the if, or not?

If yes, need { } block.

If not, indentation is wrong.