You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/17 19:27:57 UTC

[GitHub] [arrow] drabastomek commented on pull request #14434: ARROW-15538: [C++] Expanding coverage of math functions from Substrait to Acero

drabastomek commented on PR #14434:
URL: https://github.com/apache/arrow/pull/14434#issuecomment-1281368219

   Thanks @jvanstraten. You're right about the `exp` not being defined for ints - I changed the calls and added `_checked` method too. 
   
   I agree that currently all the `_checked` methods only check for int overflows and it might be something we might want to address at some point. Not sure if this should be a part of this PR tho. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org