[GitHub] [kylin] hit-lacus commented on a change in pull request #903: KYLIN-4208 RT OLAP kylin.stream.node configure optimization support all receiver can have the same config

[GitBox <gi...@apache.org>]

hit-lacus commented on a change in pull request #903: KYLIN-4208 RT OLAP kylin.stream.node configure optimization support all receiver can have the same config
URL: https://github.com/apache/kylin/pull/903#discussion_r340478444
 
 

 ##########
 File path: stream-core/src/main/java/org/apache/kylin/stream/core/util/NodeUtil.java
 ##########
 @@ -55,4 +71,29 @@ private static String getLocalhostName() {
         }
         return host;
     }
+
+    private static String getLocalHostIp() {
 
 Review comment:
   Hi, from the issue https://issues.apache.org/jira/browse/KYLIN-3747,  the author MaGang recommend to use FQDN other than ip to register receiver. So, in my view, `getLocalHostIp` is not necessary, use `getLocalhostName` maybe better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services